Skip to content

differentiate debug/release in cache key #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamadeo merged 1 commit into from
Nov 7, 2025
Merged

differentiate debug/release in cache key #5613

jamadeo merged 1 commit into from
Nov 7, 2025

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Nov 6, 2025

If we restore target/release and then do a debug build (or vice-versa), we don't benefit from those cached artifacts.

Copilot AI review requested due to automatic review settings November 6, 2025 19:04
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub Actions cache keys across multiple workflow files to distinguish between debug and release builds, preventing cache conflicts when the same runner is used for different build types.

Key Changes

  • Cache keys for CI workflows now include build type identifiers (-debug- or -release-)
  • Workflows that build release binaries use -release- suffix in their cache keys
  • The CI workflow that runs tests (debug builds) uses -debug- suffix

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/ci.yml Updated cache keys to use -cargo-debug- for debug builds used in testing
.github/workflows/pr-smoke-test.yml Updated cache keys to use -cargo-release- for release builds used in smoke tests
.github/workflows/bundle-desktop.yml Updated cache keys to use -cargo-build-release- for macOS desktop bundling
.github/workflows/bundle-desktop-windows.yml Updated cache keys to use -cargo-build-release- for Windows desktop bundling
.github/workflows/bundle-desktop-linux.yml Updated cache keys to use -cargo-release- for Linux desktop bundling
.github/workflows/bundle-desktop-intel.yml Updated cache keys to use -intel-cargo-build-release- for Intel macOS bundling
.github/workflows/build-cli.yml Updated cache keys to use -cargo-build-release- for CLI builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/bundle-desktop-linux.yml
${{ env.CARGO_HOME }}/registry/cache/
${{ env.CARGO_HOME }}/git/db/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
key: ${{ runner.os }}-cargo-release-${{ hashFiles('**/Cargo.lock') }}
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent cache key naming pattern. This workflow uses -cargo-release- while other release build workflows (bundle-desktop.yml, bundle-desktop-windows.yml, build-cli.yml) use -cargo-build-release-. Consider using -cargo-build-release- for consistency across all release build workflows.

Copilot uses AI. Check for mistakes.
.github/workflows/pr-smoke-test.yml
${{ env.CARGO_HOME }}/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
key: ${{ runner.os }}-cargo-release-${{ hashFiles('**/Cargo.lock') }}
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent cache key naming pattern. This workflow uses -cargo-release- while other release build workflows (bundle-desktop.yml, bundle-desktop-windows.yml, build-cli.yml) use -cargo-build-release-. Consider using -cargo-build-release- for consistency across all release build workflows.

Copilot uses AI. Check for mistakes.
@jamadeo jamadeo merged commit 61125ef into main Nov 7, 2025
21 checks passed
michaelneale added a commit that referenced this pull request Nov 7, 2025
@michaelneale
Merge branch 'main' into micn/goose-mobile-access
ae5e902 
* main: (21 commits)
  differentiate debug/release in cache key (#5613)
  Unify subrecipe and subagent execution through shared recipe pipeline (#5082)
  Standardize CLI argument flags and update documentation (#5516)
  Release 1.13.0
  fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575)
  fix: add standard context menu items to prevent empty right-click menu (#5616)
  Bump openapi in prepare-release (#5611)
  docs: add access control section to Developer tutorial (#5615)
  Token state not showing on load, or after message is finished. (#5606)
  Change the other location too (#5608)
  feat(ui): bring back quick launcher (#5144)
  Support platform tools through CLI (#5570)
  Avoid web double write (#5601)
  fix: gemini flash -> pro for mcp smoke tests (#5574)
  Manual compaction test and fix (#5568)
  fix: tidy up claude cli handling (#5594)
  Remove jetbrains (#5602)
  feat(githubcopilot): add support for newer Copilot AI Models (#5603)
  fix: customised recipe to yaml string to avoid minininjia parsing error (#5494)
  Add pending extension indicator to extension panel (#5493)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Nov 7, 2025
@jamadeo @fbalicchia
differentiate debug/release in cache key (block#5613)
9efad15 
Signed-off-by: fbalicchia <[email protected]>
katzdave added a commit that referenced this pull request Nov 7, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/tool-loop-cl…
0ddab9f 
…eanup

* 'main' of github.com:block/goose:
  Use session IDs as task IDs for subagents instead of UUIDs (#5398)
  Fix the naming (#5628)
  fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587)
  Fetch less and use the right SHA (#5621)
  feat(ui): add custom macOS dock menu with New Window option (#5099)
  feat: remove hints from recipe prompts (#5622)
  docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625)
  differentiate debug/release in cache key (#5613)
  Unify subrecipe and subagent execution through shared recipe pipeline (#5082)
tlongwell-block added a commit that referenced this pull request Nov 7, 2025
@tlongwell-block
Merge remote-tracking branch 'origin/main' into moim2
5607fd5 
* origin/main: (34 commits)
  Remove some logging (#5631)
  Use session IDs as task IDs for subagents instead of UUIDs (#5398)
  Fix the naming (#5628)
  fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587)
  Fetch less and use the right SHA (#5621)
  feat(ui): add custom macOS dock menu with New Window option (#5099)
  feat: remove hints from recipe prompts (#5622)
  docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625)
  differentiate debug/release in cache key (#5613)
  Unify subrecipe and subagent execution through shared recipe pipeline (#5082)
  Standardize CLI argument flags and update documentation (#5516)
  Release 1.13.0
  fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575)
  fix: add standard context menu items to prevent empty right-click menu (#5616)
  Bump openapi in prepare-release (#5611)
  docs: add access control section to Developer tutorial (#5615)
  Token state not showing on load, or after message is finished. (#5606)
  Change the other location too (#5608)
  feat(ui): bring back quick launcher (#5144)
  Support platform tools through CLI (#5570)
  ...
michaelneale added a commit that referenced this pull request Nov 10, 2025
@michaelneale
Merge branch 'main' into micn/bedrock-refresh
a6bd89e 
* main: (33 commits)
  Fix Claude Code provider to default to Auto mode (#5638) (#5642)
  Scheduler cleanup (#5571)
  Better search paths and handling of CLI providers (#5554)
  docs: description required for "Add Extension" in cli - phase 2 (#5635)
  Remove some logging (#5631)
  Use session IDs as task IDs for subagents instead of UUIDs (#5398)
  Fix the naming (#5628)
  fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587)
  Fetch less and use the right SHA (#5621)
  feat(ui): add custom macOS dock menu with New Window option (#5099)
  feat: remove hints from recipe prompts (#5622)
  docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625)
  differentiate debug/release in cache key (#5613)
  Unify subrecipe and subagent execution through shared recipe pipeline (#5082)
  Standardize CLI argument flags and update documentation (#5516)
  Release 1.13.0
  fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575)
  fix: add standard context menu items to prevent empty right-click menu (#5616)
  Bump openapi in prepare-release (#5611)
  docs: add access control section to Developer tutorial (#5615)
  ...
@github-actions github-actions bot mentioned this pull request Nov 11, 2025
Merged
Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Nov 17, 2025
@jamadeo @Surendhar-N-D
differentiate debug/release in cache key (block#5613)
6347fcd
arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025
@jamadeo @arul-g
differentiate debug/release in cache key (block#5613)
230f246
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
@jamadeo @BlairAllan
differentiate debug/release in cache key (block#5613)
40c1127 
Signed-off-by: Blair Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@alexhancock alexhancock alexhancock approved these changes

@katzdave katzdave katzdave approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamadeo @alexhancock @katzdave