fix: don't use user specific paths in mcp integration tests #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
approved these changes
Oct 29, 2025
jamadeo
reviewed
Oct 29, 2025
| CallToolRequestParam { name: "text_editor".into(), arguments: Some(object!({ | ||
| "command": "str_replace", | ||
| "path": "~/goose/crates/goose/tests/tmp/goose.txt", | ||
| "path": "/tmp/goose_test/goose.txt", |
Collaborator
There was a problem hiding this comment.
we could just delete these tests. The purpose of the snapshot test was to verify the protocol messaging, not so much the servers themselves. The developer mcp server should probably have its own integration test instead
Collaborator
Author
There was a problem hiding this comment.
I see the logic, yeah. I think I'll merge this as an improvement on current state, then we should consider quality integration tests for the developer and other built in servers.
alexhancock
force-pushed
the
alexhancock/mcp-integration-test-paths
branch
from
0130f06 to
ae5ffe4
Compare
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Nov 7, 2025
Signed-off-by: fbalicchia <fbalicchia@gmail.com>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use something like
~/goose/crates/goose/tests/tmp/goose.txtin an MCP integration test, as the final path will be different on each developer who may want to record's laptop, causing churn. I also ran into an issue because I don't store goose in my home dir.This makes it use an absolute path to a temp dir on the machine.