When the developer extension gets a cancellation message, it should kill any running processes that it owns. #4604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelahning
force-pushed
the
aning/cancelfr
branch
from
267da44 to
d9d761f
Compare
jamadeo
approved these changes
Sep 12, 2025
| &self, | ||
| notification: CancelledNotificationParam, | ||
| _context: NotificationContext<RoleServer>, | ||
| ) -> impl Future<Output = ()> + Send + '_ { |
Collaborator
There was a problem hiding this comment.
I think you can change this fn to
async fn on_cancelled(
...
) {
and then remove the async move { part
Collaborator
Author
There was a problem hiding this comment.
I had that before, but on_cancelled wasn't getting triggered.
| #[tool( | ||
| name = "shell", | ||
| description = "Execute a command in the shell. Returns output and error concatenated. Avoid commands with large output, use background commands for long-running processes." | ||
| description = "Execute a command in the shell.This will return the output and error concatenated into a single string, as you would see from running on the command line. There will also be an indication of if the command succeeded or failed. Avoid commands that produce a large amount of output, and consider piping those outputs to files. If you need to run a long lived command, background it - e.g. `uvicorn main:app &` so that this tool does not run indefinitely." |
Collaborator
There was a problem hiding this comment.
is this from another change?
Collaborator
Author
There was a problem hiding this comment.
The previous rmcp refactor trimmed the tool description. I am just adding it back.
| tokio::time::sleep(tokio::time::Duration::from_millis(1000)).await; | ||
|
|
||
| // Force kill with SIGKILL | ||
| let _sigkill_result = unsafe { libc::kill(-(pid as i32), libc::SIGKILL) }; |
Collaborator
There was a problem hiding this comment.
do you need this if you always call child.kill() on the tokio process?
Collaborator
Author
There was a problem hiding this comment.
this kills the entire process group, vs child.kill() just kills the main process.
angelahning
force-pushed
the
aning/cancelfr
branch
from
43c531d to
31ec75c
Compare
angelahning
force-pushed
the
aning/cancelfr
branch
from
31ec75c to
f9aff78
Compare
angelahning
force-pushed
the
aning/cancelfr
branch
from
85ce9b6 to
9ea4ae5
Compare
michaelneale
added a commit
that referenced
this pull request
Sep 23, 2025
* main: (26 commits) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490) feat(acp): add nicer formatting for tool names (#4686) fix gui client initialization when using an external backend (#4669) feat(acp): upgrade agent-client-protocol + improve tool experience (#4683) blog post about using subrecipes (#4647) fix: improve oneDark theme for comment contrast and readability (#4655) fix: dictation provider dropdown getting cut off (#4673) fix: Only metric a recipe run from ui on the first /reply call (#4679) fix: Don't count recipe explain or render as recipe usage (#4678) More robust test finder patch handling (#4667) fix(compaction): try to catch more context limit exceeded errors and compact (#4656) chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668) chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665) test: add test coverage for RepetitionInspector::check_tool_call (#4666) ...
Merged
zanesq
added a commit
that referenced
this pull request
Sep 23, 2025
…-unification * 'main' of github.com:block/goose: temp file for batch issue creation fix: view can recognise a dir (#4701) goosed standalone works with providers (#4698) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490)
katzdave
added a commit
that referenced
this pull request
Sep 24, 2025
…ovements * 'main' of github.com:block/goose: Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) [docs] Add gotoHuman MCP server Tutorial (#4764) fix: adjust nightly builds to first push a tag (#4704) temp file for batch issue creation fix: view can recognise a dir (#4701) goosed standalone works with providers (#4698) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688)
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…ill any running processes that it owns. (block#4604) Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4125
Screen.Recording.2025-09-10.at.3.10.37.PM.mov