Skip to content

Conversation

@alexhancock
Copy link
Collaborator

@alexhancock alexhancock commented Sep 19, 2025

Improves the acp command a bit by...

  • Upgrading the agent-client-protocol crate dep
  • Make content from tool results accessible via acp
  • Refactoring is mainly to align with the new crate

Screenshot from running in zed

Screenshot 2025-09-19 at 3 32 06 PM

Can do another followup to make tool names more human-friendly and useful

Helpful config to run goose from source (on any local branch) from zed:

# ~/.config/zed/settings.json
{
  "theme": "One Dark",
  "agent_servers": {
    "goose": {
      "command": "cargo",
      "args": [
        "+nightly",
        "-Z",
        "unstable-options",
        "-C",
        "/PATH/TO/GOOSE/REPO",
        "run",
        "--bin",
        "goose",
        "acp"
      ],
      "env": {}
    }
  }
}

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good improvement, nice one.

@alexhancock alexhancock merged commit 88dd9cb into main Sep 20, 2025
11 checks passed
@alexhancock alexhancock deleted the alexhancock/acp-tool-result-improvements branch September 20, 2025 01:07
michaelneale added a commit that referenced this pull request Sep 23, 2025
* main: (26 commits)
  Compact session automatically for streaming providers on Context Length Exceeded (#4565)
  When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604)
  Remove some unused stuff (#4388)
  Add I Ching MCP to extension catalog (#4525)
  Offer to summarize or clear conversation when it has gotten too long … (#4688)
  refactor(forge): employ desktopTemplate to support absolute paths (#4084)
  fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490)
  feat(acp): add nicer formatting for tool names (#4686)
  fix gui client initialization when using an external backend (#4669)
  feat(acp): upgrade agent-client-protocol + improve tool experience (#4683)
  blog post about using subrecipes (#4647)
  fix: improve oneDark theme for comment contrast and readability (#4655)
  fix: dictation provider dropdown getting cut off (#4673)
  fix: Only metric a recipe run from ui on the first /reply call (#4679)
  fix: Don't count recipe explain or render as recipe usage (#4678)
  More robust test finder patch handling (#4667)
  fix(compaction): try to catch more context limit exceeded errors and compact (#4656)
  chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668)
  chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665)
  test: add test coverage for RepetitionInspector::check_tool_call (#4666)
  ...
@alexhancock alexhancock mentioned this pull request Sep 23, 2025
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants