chore(mcp): convert memory mcp server to use the rust sdk for mcp #4668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexhancock
commented
Sep 17, 2025
alexhancock
commented
- Server three of the change originally in feat(rmcp-conversion): mcp server conversions #4488
- Converts memory to only use the rust sdk for mcp, and not our internal mcp-server crate
- Verified all the input schemas and tool descriptions are the exact same as before
alexhancock
force-pushed
the
alexhancock/rmcp-tutorial
branch
from
a70acb5 to
09acc1d
Compare
alexhancock
force-pushed
the
alexhancock/rmcp-memory
branch
2 times, most recently
from
dceb401 to
6ef217c
Compare
michaelneale
approved these changes
Sep 17, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
tried it out and worked nicely.
alexhancock
force-pushed
the
alexhancock/rmcp-memory
branch
from
6ef217c to
0609725
Compare
alexhancock
force-pushed
the
alexhancock/rmcp-memory
branch
from
0609725 to
08e2869
Compare
michaelneale
added a commit
that referenced
this pull request
Sep 23, 2025
* main: (26 commits) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490) feat(acp): add nicer formatting for tool names (#4686) fix gui client initialization when using an external backend (#4669) feat(acp): upgrade agent-client-protocol + improve tool experience (#4683) blog post about using subrecipes (#4647) fix: improve oneDark theme for comment contrast and readability (#4655) fix: dictation provider dropdown getting cut off (#4673) fix: Only metric a recipe run from ui on the first /reply call (#4679) fix: Don't count recipe explain or render as recipe usage (#4678) More robust test finder patch handling (#4667) fix(compaction): try to catch more context limit exceeded errors and compact (#4656) chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668) chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665) test: add test coverage for RepetitionInspector::check_tool_call (#4666) ...
Merged
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…ock#4668) Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.