fix(compaction): try to catch more context limit exceeded errors and compact #4656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
nice - yeah @katzdave may have deeper thoughts but I am sure I have hit this with anthroic specifically. |
michaelneale
approved these changes
Sep 16, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
I think ok - but ideally @katzdave can give final ok
Collaborator
Author
|
Can roll it back out if it causes any trouble or @katzdave has preference otherwise. There may also be some cleanup we can do in providers now which I can look at in followups. |
alexhancock
deleted the
alexhancock/context-limit-additional-error-catch
branch
michaelneale
added a commit
that referenced
this pull request
Sep 23, 2025
* main: (26 commits) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490) feat(acp): add nicer formatting for tool names (#4686) fix gui client initialization when using an external backend (#4669) feat(acp): upgrade agent-client-protocol + improve tool experience (#4683) blog post about using subrecipes (#4647) fix: improve oneDark theme for comment contrast and readability (#4655) fix: dictation provider dropdown getting cut off (#4673) fix: Only metric a recipe run from ui on the first /reply call (#4679) fix: Don't count recipe explain or render as recipe usage (#4678) More robust test finder patch handling (#4667) fix(compaction): try to catch more context limit exceeded errors and compact (#4656) chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668) chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665) test: add test coverage for RepetitionInspector::check_tool_call (#4666) ...
Merged
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…compact (block#4656) Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a context limit exceeded error while using an anthropic model that was not caught by the provider specific error parsing in
crates/goose/src/providers/anthropic.rsConsidering adding this as a catchall at the top level.