fix: adjust nightly builds to first push a tag #4704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhancock
force-pushed
the
alexhancock/nightly-tags
branch
from
133efc7 to
bb20ba0
Compare
jamadeo
approved these changes
Sep 23, 2025
.github/workflows/nightly.yml
Outdated
| run: | | ||
| TAG="${{ needs.prepare-version.outputs.version }}" | ||
| # Validate version format (expects format like: x.y.z-nightly.YYYYMMDD) |
Collaborator
There was a problem hiding this comment.
seems a little out of place, if we think it could be invalid shouldn't it validate in the step where it is created?
.github/workflows/nightly.yml
Outdated
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| # Force create and push tag (overwrites if exists) |
Collaborator
There was a problem hiding this comment.
is the forcing necessary? consider if we can have that off at least by default
alexhancock
force-pushed
the
alexhancock/nightly-tags
branch
from
bb20ba0 to
cc45e23
Compare
katzdave
added a commit
that referenced
this pull request
Sep 24, 2025
…ovements * 'main' of github.com:block/goose: Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) [docs] Add gotoHuman MCP server Tutorial (#4764) fix: adjust nightly builds to first push a tag (#4704) temp file for batch issue creation fix: view can recognise a dir (#4701) goosed standalone works with providers (#4698) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688)
tlongwell-block
pushed a commit
that referenced
this pull request
Sep 25, 2025
alexhancock
added a commit
that referenced
this pull request
Sep 29, 2025
This reverts commit 6fc49d0.
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing the above error that happens in nightly builds at present
Example: https://github.com/block/goose/actions/runs/17936231221/job/51003691059
This also allows manual testing of the workflow so I can diagnose if anything still doesn't work on a branch after this change merges.