refactor(forge): employ desktopTemplate to support absolute paths #4084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exec & icon Signed-off-by: Jason Cochard <[email protected]>
Collaborator
DOsinga
approved these changes
Sep 19, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
oops, it looks like I never submittee my review. appologies!
| maintainer: 'Block, Inc.', | ||
| homepage: 'https://block.github.io/goose/', | ||
| categories: ['Development'], | ||
| mimeType: ['x-scheme-handler/goose'], |
Collaborator
There was a problem hiding this comment.
why did this get deleted?
Contributor
Author
There was a problem hiding this comment.
This line gets transmuted into the MimeType line in the resulting .desktop file.
The presence of the desktopTemplate line in the forge config causes the defined desktop file to pass through electronforge unchanged iirc.
So it's initially confusing because 'desktopTemplate' here seems to mean a hardcoded file with no symbol substitution behavior from electronforge.
michaelneale
added a commit
that referenced
this pull request
Sep 23, 2025
* main: (26 commits) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490) feat(acp): add nicer formatting for tool names (#4686) fix gui client initialization when using an external backend (#4669) feat(acp): upgrade agent-client-protocol + improve tool experience (#4683) blog post about using subrecipes (#4647) fix: improve oneDark theme for comment contrast and readability (#4655) fix: dictation provider dropdown getting cut off (#4673) fix: Only metric a recipe run from ui on the first /reply call (#4679) fix: Don't count recipe explain or render as recipe usage (#4678) More robust test finder patch handling (#4667) fix(compaction): try to catch more context limit exceeded errors and compact (#4656) chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668) chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665) test: add test coverage for RepetitionInspector::check_tool_call (#4666) ...
Merged
zanesq
added a commit
that referenced
this pull request
Sep 23, 2025
…-unification * 'main' of github.com:block/goose: temp file for batch issue creation fix: view can recognise a dir (#4701) goosed standalone works with providers (#4698) Compact session automatically for streaming providers on Context Length Exceeded (#4565) When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604) Remove some unused stuff (#4388) Add I Ching MCP to extension catalog (#4525) Offer to summarize or clear conversation when it has gotten too long … (#4688) refactor(forge): employ desktopTemplate to support absolute paths (#4084) fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490)
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…ock#4084) Signed-off-by: Jason Cochard <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #4079 we'll need electron forge to spit out a desktop file with an absolute path for the 'Exec' line. This change directs each linux maker to use a flat, pre-filled desktop file that electronforge calls a 'desktopTemplate'.
The
Iconline benefits from this change as well as it is now an absolute path.