Skip to content

Conversation

@ewann
Copy link
Contributor

@ewann ewann commented Sep 3, 2025

Pull Request Description

A flake.nix seems recently added to the repo. As a self contained unit, it is currently missing software necessary as part of the existing goose dev/build environment. In the absence of information why they are deliberately absent, it appears to make sense to add that software, particularly as it all appears to already exist in nixpkgs.

I've additionally added gemini-cli. This isn't a requirement for the existing documented build process, however
a) it is useful to developers working with that ecosystem
b) doesn't appear to pollute the dev/build environment in any harmful way
c) potentially supports more deterministic outcomes


@ewann ewann force-pushed the add-missing-helpful-nixpkgs branch from eaf9a58 to 2536f76 Compare September 3, 2025 03:03
@ewann
Copy link
Contributor Author

ewann commented Sep 3, 2025

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ewann

@ewann
Copy link
Contributor Author

ewann commented Sep 9, 2025

@michaelneale you mentioned for me to merge when green, but I don't appear to have the powers for that - if you could please merge for me when you have a moment?

@blackgirlbytes blackgirlbytes merged commit 0ee1766 into block:main Sep 22, 2025
10 checks passed
michaelneale added a commit that referenced this pull request Sep 23, 2025
* main: (26 commits)
  Compact session automatically for streaming providers on Context Length Exceeded (#4565)
  When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604)
  Remove some unused stuff (#4388)
  Add I Ching MCP to extension catalog (#4525)
  Offer to summarize or clear conversation when it has gotten too long … (#4688)
  refactor(forge): employ desktopTemplate to support absolute paths (#4084)
  fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490)
  feat(acp): add nicer formatting for tool names (#4686)
  fix gui client initialization when using an external backend (#4669)
  feat(acp): upgrade agent-client-protocol + improve tool experience (#4683)
  blog post about using subrecipes (#4647)
  fix: improve oneDark theme for comment contrast and readability (#4655)
  fix: dictation provider dropdown getting cut off (#4673)
  fix: Only metric a recipe run from ui on the first /reply call (#4679)
  fix: Don't count recipe explain or render as recipe usage (#4678)
  More robust test finder patch handling (#4667)
  fix(compaction): try to catch more context limit exceeded errors and compact (#4656)
  chore(mcp): convert memory mcp server to use the rust sdk for mcp (#4668)
  chore(mcp): convert tutorial mcp server to use the rust sdk for mcp (#4665)
  test: add test coverage for RepetitionInspector::check_tool_call (#4666)
  ...
@alexhancock alexhancock mentioned this pull request Sep 23, 2025
zanesq added a commit that referenced this pull request Sep 23, 2025
…-unification

* 'main' of github.com:block/goose:
  temp file for batch issue creation
  fix: view can recognise a dir (#4701)
  goosed standalone works with providers (#4698)
  Compact session automatically for streaming providers on Context Length Exceeded (#4565)
  When the developer extension gets a cancellation message, it should kill any running processes that it owns. (#4604)
  Remove some unused stuff (#4388)
  Add I Ching MCP to extension catalog (#4525)
  Offer to summarize or clear conversation when it has gotten too long … (#4688)
  refactor(forge): employ desktopTemplate to support absolute paths (#4084)
  fix(nix): add nixpkgs missing for existing build process & useful in dev process (#4490)
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
…dev process (block#4490)

Signed-off-by: Ewan Nisbet <[email protected]>
Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants