Skip to content

refactor(forge): employ desktopTemplate to support absolute paths #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 1 commit into from
Sep 22, 2025
Merged

refactor(forge): employ desktopTemplate to support absolute paths #4084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/desktop/forge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ module.exports = {
maintainer: 'Block, Inc.',
homepage: 'https://block.github.io/goose/',
categories: ['Development'],
mimeType: ['x-scheme-handler/goose'],
Copy link
Collaborator

@DOsinga DOsinga Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this get deleted?

Copy link
Contributor Author

@eyelight eyelight Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line gets transmuted into the MimeType line in the resulting .desktop file.

The presence of the desktopTemplate line in the forge config causes the defined desktop file to pass through electronforge unchanged iirc.

So it's initially confusing because 'desktopTemplate' here seems to mean a hardcoded file with no symbol substitution behavior from electronforge.

desktopTemplate: './forge.deb.desktop',
options: {
icon: 'src/images/icon.png'
}
Expand All @@ -84,6 +84,7 @@ module.exports = {
maintainer: 'Block, Inc.',
homepage: 'https://block.github.io/goose/',
categories: ['Development'],
desktopTemplate: './forge.rpm.desktop',
options: {
icon: 'src/images/icon.png'
}
Expand Down
8 changes: 8 additions & 0 deletions ui/desktop/forge.deb.desktop
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[Desktop Entry]
Name=Goose
Exec=/usr/lib/goose/Goose %U
Icon=/usr/share/pixmaps/goose.png
Terminal=false
Type=Application
Categories=Development;
MimeType=x-scheme-handler/goose;
8 changes: 8 additions & 0 deletions ui/desktop/forge.rpm.desktop
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[Desktop Entry]
Name=Goose
Exec=/usr/lib/Goose/Goose %U
Icon=/usr/share/pixmaps/Goose.png
Terminal=false
Type=Application
Categories=Development;
MimeType=x-scheme-handler/goose;
Loading