feat(google_drive): set read/write scope on all commands to use the same token #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakiali
reviewed
Mar 15, 2025
| use google_sheets4::{self, Sheets}; | ||
| use http_body_util::BodyExt; | ||
|
|
||
| const GOOGLE_DRIVE_SCOPES: Scope = Scope::Full; |
Collaborator
There was a problem hiding this comment.
any worry about deletions or unwanted consequences from changing this to full (which I assume is read and manage everything?). Guess this also depends on what you're enabling with the tools, which are reasonable
Contributor
Author
There was a problem hiding this comment.
yeaaa, definitely worried it could go wild.
just looked and saw that while we have allow_shared_drives as a bool, the tool didn't actually do anything with it so that should be fixed first
Collaborator
There was a problem hiding this comment.
yes, could probably stop it from deleting, and I think there are drive options to keep changes so things are not lost.
Contributor
Author
There was a problem hiding this comment.
okay this is updated and fixed up a couple other bugs during testing
…ame token the readonly commands would re-initiate the oauth flow after a write call, and vice versa, since they only requested a single differing scope
previously the parameters were exctracting parent and supportAllDrives, when the tool parameters were parent_id and allow_shared_drives
kalvinnchau
force-pushed
the
kalvin/google-drive-scopes
branch
from
5fd0fc3 to
e659e10
Compare
zakiali
approved these changes
Mar 17, 2025
michaelneale
added a commit
that referenced
this pull request
Mar 18, 2025
* main: chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) docs: fix docusaurus sidebar limit (#1722) docs: Add Session List To CLI Commands Guide (#1729) ui: start extensions on add (#1714) ui: new extensions modal (#1711) docs: Add Filesystem Short Video to Tutorial (#1723) fix: update the mcp client protocol version to 2024-11-05 (#1690)
salman1993
added a commit
that referenced
this pull request
Mar 20, 2025
* origin/main: (74 commits) config: add optional extension description (#1743) docs: add deployment for install link generator (#1737) ui: new configure provider flow (#1736) Revert "Standardize Radio Button input" (#1758) Settings v2 Add Model (#1708) fix: use lowercase names for builtin external extensions (#1756) chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) ...
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the fact that the readonly commands would re-initiate the oauth flow after a write call, and vice versa, since they only requested a single differing scope