feat docker via scheme - #1
Closed
bwalding wants to merge 2 commits into
Closed
Conversation
bwalding
force-pushed
the
feat-docker-via-scheme
branch
from
May 12, 2025 08:13
40520e9 to
52cd139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dockerto the list of allowed commands to install via deeplinks.Given that upx / npx can run arbitrary code from a repository, this doesn't seem to be a change in the security threat model.
There is also a "good" argument that docker could be a first-class command type rather than just another command invoked by a shell - but that won't be addressed here.