Issue 1667 - update the client protocol string to match the spec #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
approved these changes
Mar 14, 2025
Contributor
|
might be worth updating this one too - goose/crates/mcp-client/src/client.rs Line 248 in 8bda119 curious was this leading to any errors? |
…f the spec it implements
Contributor
Author
That was the one I updated - I can't see anything else related to protocol version: ➜ goose git:(issue-1667) grep --include '*.rs' -ir "protocol_version" .
./crates/mcp-core/src/protocol.rs: pub protocol_version: String,
./crates/mcp-server/src/router.rs: protocol_version: "2024-11-05".to_string(),
./crates/mcp-client/src/client.rs: pub protocol_version: String,
./crates/mcp-client/src/client.rs: protocol_version: "2024-11-05".to_string(),
Not inside Goose itself. But I was using https://github.com/llmcontext/gomcp as a server and it validates the client is sending a known protocol version (1.0.0 is not a version it expects). So I couldn't attach Goose to the server without changing one end or the other. And it made sense to me to update Goose to send the correct protocol version. |
lily-de
pushed a commit
that referenced
this pull request
Mar 17, 2025
docs: Add Filesystem Short Video to Tutorial (#1723) separate args and command get rid of args add delete button make scrollable and fix bottom button spacing add button form validation allow esc key + click background to close modal; update providers modal fix providers modal add padding to add button add button styling move standalone functions to utils update the import tweaks add some update agent functionality Delete ui/desktop/src/agent/extensions.tsx add shim improve load experience
michaelneale
added a commit
that referenced
this pull request
Mar 18, 2025
* main: chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) docs: fix docusaurus sidebar limit (#1722) docs: Add Session List To CLI Commands Guide (#1729) ui: start extensions on add (#1714) ui: new extensions modal (#1711) docs: Add Filesystem Short Video to Tutorial (#1723) fix: update the mcp client protocol version to 2024-11-05 (#1690)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the same pattern as for the proxy/server code - just put the string directly into the response.
There's an argument for extracting the protocol version out of the schema when it generates all the code - but that's a much much bigger change - and not something a drive-by contributor can do!