ui: new configure provider flow #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lily-de
commented
Mar 18, 2025
|
|
||
| useEffect(() => window.electron.reactReady(), []); | ||
|
|
||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
not gone just moved -- this always runs
lily-de
commented
Mar 18, 2025
| }; | ||
|
|
||
| // Utility function to extract the command from the link | ||
| function extractCommand(link: string): string { |
Contributor
Author
There was a problem hiding this comment.
not gone just moved -- always available
lily-de
commented
Mar 18, 2025
| }, []); | ||
|
|
||
| // Attempt to detect config for a stored provider | ||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
moved into separate hook below (ctrl+f for detectStoredProvider)
lily-de
commented
Mar 18, 2025
| }, []); | ||
|
|
||
| // Initialize system if we have a stored provider | ||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
moved into conditional hook -- look for setupStoredProvider below
lily-de
commented
Mar 18, 2025
| }, [view]); | ||
|
|
||
| // TODO: modify | ||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
same function as before, just moved
lily-de
commented
Mar 18, 2025
Comment on lines
+222
to
+224
| const { switchModel } = useModel(); // TODO: remove | ||
| const { addRecentModel } = useRecentModels(); // TODO: remove | ||
|
|
Contributor
Author
There was a problem hiding this comment.
same as before just moved
lily-de
commented
Mar 18, 2025
| const { switchModel } = useModel(); // TODO: remove | ||
| const { addRecentModel } = useRecentModels(); // TODO: remove | ||
|
|
||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
new conditional hook -- the old process for starting the app and getting the state of the providers is here
lily-de
commented
Mar 18, 2025
|
|
||
| setupExtensions(); | ||
| }, []); // Empty dependency array since we're using initAttemptedRef | ||
| const initializeApp = async () => { |
Contributor
Author
There was a problem hiding this comment.
new way to initialize app -- can break into separate useEffect's when we're ready
lily-de
commented
Mar 18, 2025
| const initAttemptedRef = useRef(false); | ||
|
|
||
| // Utility function to extract the command from the link | ||
| function extractCommand(link: string): string { |
Contributor
Author
There was a problem hiding this comment.
just moved from below
alexhancock
approved these changes
Mar 18, 2025
salman1993
added a commit
that referenced
this pull request
Mar 20, 2025
* origin/main: (74 commits) config: add optional extension description (#1743) docs: add deployment for install link generator (#1737) ui: new configure provider flow (#1736) Revert "Standardize Radio Button input" (#1758) Settings v2 Add Model (#1708) fix: use lowercase names for builtin external extensions (#1756) chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) ...
michaelneale
added a commit
that referenced
this pull request
Mar 20, 2025
* main: fix: check if working directory has changed before asking (#1733) extensions: add a display name field (#1759) ui: add logs to app (#1760) docs: add stdin (#1769) config: add optional extension description (#1743) docs: add deployment for install link generator (#1737) ui: new configure provider flow (#1736) Revert "Standardize Radio Button input" (#1758) Settings v2 Add Model (#1708) fix: use lowercase names for builtin external extensions (#1756)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses config for the alpha feature flag -- also moved other functions around, tagging which ones we can get rid of once we are ready to test settings v2 end to end and ones that need modifications
I also put some old functions into a separate conditional hook
structure of the file: