ui: start extensions on add #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lily-de
force-pushed
the
ldelalande/start-extensions-on-add
branch
2 times, most recently
from
4e88fcf to
ed719be
Compare
docs: Add Filesystem Short Video to Tutorial (#1723) separate args and command get rid of args add delete button make scrollable and fix bottom button spacing add button form validation allow esc key + click background to close modal; update providers modal fix providers modal add padding to add button add button styling move standalone functions to utils update the import tweaks add some update agent functionality Delete ui/desktop/src/agent/extensions.tsx add shim improve load experience
lily-de
force-pushed
the
ldelalande/start-extensions-on-add
branch
from
ed719be to
e3c085e
Compare
matthewdiamant
approved these changes
Mar 17, 2025
Contributor
matthewdiamant
left a comment
matthewdiamant
left a comment
There was a problem hiding this comment.
Looks great! 👍
There's a lot of console.log statements still, do we need all of them?
|
|
||
| // extensionUpdate = an extension was newly added or updated so we should attempt to add it | ||
|
|
||
| export const useAgent = () => { |
Contributor
There was a problem hiding this comment.
Should this file also be called useAgent.tsx instead of UpdateAgent?
| const [isUpdating, setIsUpdating] = useState(false); | ||
|
|
||
| // whenever we change the model, we must call this | ||
| const initializeAgent = async (provider: string, model: string) => { |
Contributor
There was a problem hiding this comment.
nit: Maybe we should call this restartAgent? initializeAgent is currently also what the function in utils.tsx is called.
Contributor
Author
There was a problem hiding this comment.
i think i will refactor a bit so will just leave like this for now :D
will get rid of log statements then too
michaelneale
added a commit
that referenced
this pull request
Mar 18, 2025
* main: chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) docs: fix docusaurus sidebar limit (#1722) docs: Add Session List To CLI Commands Guide (#1729) ui: start extensions on add (#1714) ui: new extensions modal (#1711) docs: Add Filesystem Short Video to Tutorial (#1723) fix: update the mcp client protocol version to 2024-11-05 (#1690)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
Co-authored-by: Ben Walding <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Co-authored-by: Ben Walding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge #1711 first