Skip to content

Conversation

@lily-de
Copy link
Contributor

@lily-de lily-de commented Mar 16, 2025

Updates settings v2 extensions modal design to match latest in Figma

Formerly:
image

Now:
Screenshot 2025-03-15 at 5 59 22 PM

Designs:
Screenshot 2025-03-15 at 5 59 35 PM

Tweaks (design side):

  1. No description because we need to update the rust side to expect that field and that will be a separate PR
  2. Combined Command + Args because separate is confusing

Design left to do for this modal (maybe will get to it before monday):
1. Can't for the life of me figure out how to make the drop down not black and I spent over a full day on this 💀 so i want to call this 'good enough' for now and can adjust later / maybe before this PR is even reviewed
2. Need to make the inputs box backgrounds same color as rest of modal

Tweaks (impl side):

  1. Form validation shows what fields need to be filled after submission
  2. Included ability to delete existing extensions via the modal

Suggestions:

  • Links to the docs on how to fill these out

Copy link
Contributor Author

@lily-de lily-de Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ability to exit via esc / clicking out

Also created a footer prop for passing in the buttons at the bottom -- makes having very long modals scrollable. You can always see the buttons at the bottom, and contents become scrollable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also not use the footer, but then if the modal is very long, you have to scroll to find the buttons at the bottom (see the provider modals -- need to fix those in another pr)

@lily-de lily-de force-pushed the ldelalande/new-extensions-modal branch from 7220b16 to 13fa2b8 Compare March 16, 2025 01:08
@alexhancock alexhancock self-requested a review March 17, 2025 15:42
@lily-de lily-de merged commit 27a9121 into main Mar 17, 2025
6 checks passed
@lily-de lily-de deleted the ldelalande/new-extensions-modal branch March 17, 2025 16:11
lily-de added a commit that referenced this pull request Mar 17, 2025
…nsions-on-add

* origin/main:
  ui: new extensions modal (#1711)
  docs: Add Filesystem Short Video to Tutorial (#1723)
  fix: update the mcp client protocol version to 2024-11-05 (#1690)
michaelneale added a commit that referenced this pull request Mar 18, 2025
* main:
  chore(release): release version 1.0.15 (#1749)
  docs: goosing around: langfuse blog (#1746)
  feat: update the deny call response (#1741)
  feat: refactor register eval (#1713)
  fix: Goose UI fix typos (#1744)
  feat(google_drive): comment read (#1732)
  feat: build cli workflow  (#1697)
  fix: fix initial model configuration in cli when using toolshim (#1720)
  feat: add basic support for aws bedrock to desktop app (#1271)
  feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735)
  Standardize Radio Button input (#1701)
  ui: tweaks to settings v2 (#1731)
  feat(google_drive): set read/write scope on all commands to use the same token (#1707)
  refactor: clean up log usage (#1704)
  docs: fix docusaurus sidebar limit (#1722)
  docs: Add Session List To CLI Commands Guide (#1729)
  ui: start extensions on add (#1714)
  ui: new extensions modal (#1711)
  docs: Add Filesystem Short Video to Tutorial (#1723)
  fix: update the mcp client protocol version to 2024-11-05 (#1690)
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants