-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: add basic support for aws bedrock to desktop app #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have rebased to resolve a recent conflict, and added AWS Bedrock to |
|
@Quentin-M -- right now settings_v2 is under construction and not used in the main app. If this is something you'd like to expose to users in the next release, i think it needs to go to settings (v1). If you'd like to integrate this into the current settings and need assistance, let me know. But, moving forward, take a look more closely at settings_v2 as it is right now, we are using |
|
@lily-de Thanks. Happy to remove the inclusion of Bedrock from the WIP |
|
hey @Quentin-M Should |
|
@kalvinnchau Thank you for pointing it you, it indeed works as expected simply with the profile configured, and somehow didn't even question it. I have therefore only kept this variable. I also have amended the description in |
|
sorry this took so long! re-running the workflows and gonna merge after |
|
oh looks like we need to add an import to the bedrock.rs file https://github.com/block/goose/actions/runs/13845191109/job/38932666805#step:11:529 |
* main: chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) docs: fix docusaurus sidebar limit (#1722) docs: Add Session List To CLI Commands Guide (#1729) ui: start extensions on add (#1714) ui: new extensions modal (#1711) docs: Add Filesystem Short Video to Tutorial (#1723) fix: update the mcp client protocol version to 2024-11-05 (#1690)
* origin/main: (74 commits) config: add optional extension description (#1743) docs: add deployment for install link generator (#1737) ui: new configure provider flow (#1736) Revert "Standardize Radio Button input" (#1758) Settings v2 Add Model (#1708) fix: use lowercase names for builtin external extensions (#1756) chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) ...



This PR addresses #1214.
The provider setup window requires the AWS_PROFILE and AWS_REGION variables., which implies that a valid AWS Profile has already been configured in the user's
~/.aws/configfile, akin the CLI implementation.Access/secret keys could be requested instead, but profiles are significantly more flexible, and enable usage of SSO, role assumptions, etc, etc.