#270 - Merge Hotfix V2.1.2 to main #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewsignori-aot
commented
Dec 12, 2024
andrewsignori-aot
commented
- Hotfix 2.1.2 merge to main.
- Fix E2E for the new program year.
Moving the latest changes from Bull Scheduler to release 2.1.
- Created a new table to map SFAS code to SIMS legacy restriction codes. - New records added to the table map will be automatically added to the `sims.restrcitions` if not present yet. - The column `is_legacy_only` creates a distinction between the SFAS-SIMS mapped restriction and the restrictions that should be added to SIMS but not managed (only resolved). - Kept generating a notification for each student that had a new legacy restriction added. - The creation date is controlled and the query to get students looks for any new student restriction created by the import process. ### Rollback  
…Calculations (#4042) Ignore Cancelled Legacy Applications on SIMS Validations and Calculations
- Prevent API from retuning 'No effect' notifications since they are not supposed to be notified to the student. - Consolidated `LGCY_*` restrictions into a single `LGCY` restriction code to be returned to the student. The error code returned will be the highest one present in the list of the `LGCY_*` being returned. - Create few `LGCY_*` in the DB seed to allow the E2E to use them. - Fixed the `db:seed:test:clean` that was not removing the `create_history_entry` function leading to an error when the DB was populated again. - Close Nestjs app (`app.close()`) to avoid the `db:seed:test:clean` and `db:seed:test` to be hanging and waiting. ### Ministry visualization for the new legacy map  ### SQL to be manually added during release ```sql INSERT INTO sims.sfas_restriction_maps (legacy_code, code, is_legacy_only) VALUES ('TD', 'LGCY_TD', TRUE), ('B5', 'LGCY_B5', TRUE), ('B5A', 'LGCY_B5A', TRUE), ('B7', 'LGCY_B7', TRUE), ('SSD', 'LGCY_SSD', TRUE), ('Z2', 'LGCY_Z2', TRUE), ('M1', 'LGCY_M1', TRUE), ('SSRN', 'LGCY_SSRN', TRUE), ('B4', 'LGCY_B4', TRUE), ('Z1', 'LGCY_Z1', TRUE) ```
…4058) Fix the legacy program year totals for program year limits
…#4084) Removed the code setting the first disbursement back for today. ### Sample application when the offering start date is ahead (2 disbursements)  ### Sample application when the offering start date is in the past (2 disbursements) 
andrewsignori-aot
added
the
Branch Sync-up
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
Dec 12, 2024
bidyashish
approved these changes
Dec 12, 2024
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.