#4052 - Fix the legacy program year totals for program year limits #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
| sequencedApplications.current.referenceAssessmentDate ?? | ||
| options?.alternativeReferenceDate; | ||
| // Convert the reference assessment date to an ISO date format. | ||
| const formattedReferenceAssessmentDate = getISODateOnlyString( |
There was a problem hiding this comment.
Minor but the methods should receive as much as possible the Date as it is. Converting it to the ISO date is a concern for the method executing the query.
I do recognize the programYearStartDate already receiving it as string because comes directly from typeorm date only.
Since the methods are private it would not be a blocker.
andrewsignori-aot
approved these changes
Dec 10, 2024
andrepestana-aot
approved these changes
Dec 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Merge Hotfix V2.1.1 to Main ## What's Changed * #4013 - Legacy Restriction Mapping - Migrations and SQL Changes by @andrewsignori-aot in #4037 * #4041 - Ignore Cancelled Legacy Applications on SIMS Validations and Calculations by @dheepak-aot in #4042 * #4013 - Legacy Restriction Mapping - Student Changes by @andrewsignori-aot in #4049 * #4052 - Fix the legacy program year totals for program year limits by @dheepak-aot in #4058 --------- Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
dheepak-aot
deleted the
fix/#4052-program-year-limits-from-sfas-bridge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the legacy program year totals for program year limits
current dateas reference assessment date.