Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4041 - Ignore Cancelled Legacy Applications on SIMS Validations and Calculations #4042

Merged
merged 8 commits into from
Dec 9, 2024
Merged

#4041 - Ignore Cancelled Legacy Applications on SIMS Validations and Calculations #4042

merged 8 commits into from
Dec 9, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Dec 6, 2024 •
edited
Loading

Ignore Cancelled Legacy Applications on SIMS Validations and Calculations

  • Updated the condition to validate study period overlap ignoring the SFAS FT applications with a cancelled date.
  • Updated the condition to calculate program year award totals ignoring the SFAS FT applications with a cancelled date.
  • Updated the condition to calculate legacy BCSL total ignoring the SFAS FT applications with a cancelled date.

FT Legacy BCSL Bug Fix

  • Updated the totalLegacyBCSLAmount method to query based on student id and not the sfas_individual_id.

image

E2E

  • Added API E2E test for ignoring SFAS FT applications with a cancelled date during study period overlap.
  • Added Worker E2E test for ignoring SFAS FT application(s) with a cancelled date during program year awards total calculation.
  • Added Queue Consumers E2E Test for life time maximum BCSL including the awards from Legacy.

@dheepak-aot dheepak-aot self-assigned this Dec 6, 2024
@dheepak-aot dheepak-aot marked this pull request as ready for review December 7, 2024 01:11
@bidyashish bidyashish added the Hotfix PR created for hotfix label Dec 9, 2024
andrewsignori-aot
andrewsignori-aot reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and great findngs, please take a look at the comments.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.04% ( 3727 / 16912 )
Methods: 10.15% ( 214 / 2109 )
Lines: 25.37% ( 3235 / 12750 )
Branches: 13.54% ( 278 / 2053 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.39% ( 1238 / 1467 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.61% ( 1053 / 1230 )
Branches: 68.42% ( 65 / 95 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.94% ( 5774 / 8625 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.87% ( 4531 / 6393 )
Branches: 46.71% ( 525 / 1124 )

andrewsignori-aot
andrewsignori-aot approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, looks good 👍

andrepestana-aot
andrepestana-aot approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job!

@dheepak-aot dheepak-aot merged commit 39031e4 into hotfix/v2.1.1 Dec 9, 2024
21 checks passed
@bidyashish bidyashish mentioned this pull request Dec 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@bidyashish @andrewsignori-aot @dheepak-aot
#267 - Merge Hotfix V2.1.1 to Main (#4065)
123e354 
Merge Hotfix V2.1.1 to Main

## What's Changed
* #4013 - Legacy Restriction Mapping - Migrations and SQL Changes by
@andrewsignori-aot in #4037
* #4041 - Ignore Cancelled Legacy Applications on SIMS Validations and
Calculations by @dheepak-aot in #4042
* #4013 - Legacy Restriction Mapping - Student Changes by
@andrewsignori-aot in #4049
* #4052 - Fix the legacy program year totals for program year limits by
@dheepak-aot in #4058

---------

Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
@dheepak-aot dheepak-aot deleted the fix/#4041-ignore-cancelled-ft-legacy-applications branch December 13, 2024 00:10
@andrewsignori-aot andrewsignori-aot mentioned this pull request Dec 19, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@dheepak-aot dheepak-aot

Labels
E2E/Unit tests Hotfix PR created for hotfix Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dheepak-aot @andrewsignori-aot @andrepestana-aot @bidyashish