Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4082 - 2 Disbursement PT Schedules - Correct First Disbursement Date #4084

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 12, 2024

Removed the code setting the first disbursement back for today.

Sample application when the offering start date is ahead (2 disbursements)

image

Sample application when the offering start date is in the past (2 disbursements)

image

@andrewsignori-aot andrewsignori-aot added Camunda Worflow Involves camunda workflow changes Hotfix PR created for hotfix labels Dec 12, 2024
@andrewsignori-aot andrewsignori-aot self-assigned this Dec 12, 2024
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 12, 2024 21:00
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.01% ( 3728 / 16934 )
Methods: 10.13% ( 214 / 2112 )
Lines: 25.35% ( 3236 / 12767 )
Branches: 13.53% ( 278 / 2055 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.39% ( 1238 / 1467 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.61% ( 1053 / 1230 )
Branches: 68.42% ( 65 / 95 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks for the fix. 👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.09% ( 5799 / 8644 )
Methods: 65.05% ( 722 / 1110 )
Lines: 70.98% ( 4548 / 6407 )
Branches: 46.94% ( 529 / 1127 )

Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@andrewsignori-aot andrewsignori-aot merged commit 04877ba into hotfix/v2.1.2 Dec 12, 2024
21 checks passed
@andrewsignori-aot andrewsignori-aot deleted the fix/#4082-two-disbursement-pt-schedules-first-date branch December 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Worflow Involves camunda workflow changes Hotfix PR created for hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants