Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to handle imported cancelled SFAS applications #4041

Closed
3 tasks done
Joshua-Lakusta opened this issue Dec 6, 2024 · 2 comments
Closed
3 tasks done

Add action to handle imported cancelled SFAS applications #4041

Joshua-Lakusta opened this issue Dec 6, 2024 · 2 comments
Assignees
Labels
Business Items under Business Consideration Enhancement New feature or request Hotfix PR created for hotfix User Story

Comments

@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Dec 6, 2024

As a student I need my cancelled applications in SFAS (application_cancel_date) to be treated as if they do not exist. This means all areas where we import SFAS application data and utilize it should ignore cancelled application data when calculating or validating.

Acceptance Criteria

  • Should not trigger date overlap validation if application has been cancelled (cancelled apps should be ignored during this process)
  • Program year limit amounts for applications that have been cancelled should be ignored
  • Total Legacy BCSL amount should be ignored for cancelled apps (calculation for BC lifetime max full time)

Additional Context
Currently blocking students from being able to submit as we are not digesting the information for application_Cancel_date from SFAS

Not addressing MSFAA as SFAS apps do not effect PT applications and we need to do further investigation on when MSFAA is validated. Another ticket will be created if deemed neccessary.

@Joshua-Lakusta Joshua-Lakusta added Enhancement New feature or request User Story labels Dec 6, 2024
@Joshua-Lakusta Joshua-Lakusta self-assigned this Dec 6, 2024
@Joshua-Lakusta Joshua-Lakusta added the Business Items under Business Consideration label Dec 6, 2024
@Joshua-Lakusta Joshua-Lakusta changed the title Add action to handle imported cancelled legacy application Add action to handle imported cancelled SFAS applications Dec 6, 2024
@dheepak-aot dheepak-aot added the Hotfix PR created for hotfix label Dec 6, 2024
dheepak-aot added a commit that referenced this issue Dec 9, 2024
…Calculations (#4042)

Ignore Cancelled Legacy Applications on SIMS Validations and Calculations
@dheepak-aot
Copy link
Collaborator

dheepak-aot commented Dec 10, 2024

There was a technical bug in deriving total legacy BCSL value for FT. (Student id was checked against sfas_individual id instead of individual linked student id). This bug has been fixed during the implementation and added E2E test to mitigate the risk.

@CarlyCotton
Copy link
Collaborator

Checked cancelled sfas app with an overlap in SIMS. SIMS allowed app and did NOT use any award amounts in PY totals.

github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
Merge Hotfix V2.1.1 to Main

## What's Changed
* #4013 - Legacy Restriction Mapping - Migrations and SQL Changes by
@andrewsignori-aot in #4037
* #4041 - Ignore Cancelled Legacy Applications on SIMS Validations and
Calculations by @dheepak-aot in #4042
* #4013 - Legacy Restriction Mapping - Student Changes by
@andrewsignori-aot in #4049
* #4052 - Fix the legacy program year totals for program year limits by
@dheepak-aot in #4058

---------

Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Business Items under Business Consideration Enhancement New feature or request Hotfix PR created for hotfix User Story
Projects
None yet
Development

No branches or pull requests

3 participants