Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 Disbursement PT Schedules - Correct First Disbursement Date #4082

Closed
CarlyCotton opened this issue Dec 12, 2024 · 2 comments
Closed

2 Disbursement PT Schedules - Correct First Disbursement Date #4082

CarlyCotton opened this issue Dec 12, 2024 · 2 comments
Assignees
@andrewsignori-aot @CarlyCotton
Labels
Business Items under Business Consideration Ministry Ministry Features

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Dec 12, 2024 •
edited
Loading

User Story
When a student has a PT application where there is an offering study start date AFTER today with 2 potential disbursements AND date(disbursmenentScheduleDate2Potential) > today()... the earliest date of disbursement should be the offering study start date.

Current Behaviour
Disbursement schedule is resetting the disbursement 1 schedule date to today() .. instead of using the previously assigned offeringstudystartdate

Expected Behaviour
Disbursement 1 date should be today's date ONLY if the study start date has passed.

image.png

image.png
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Dec 12, 2024
@CarlyCotton CarlyCotton self-assigned this Dec 12, 2024
@CarlyCotton CarlyCotton added the Ministry Ministry Features label Dec 12, 2024
@CarlyCotton CarlyCotton mentioned this issue Dec 12, 2024
Closed
andrewsignori-aot added a commit that referenced this issue Dec 12, 2024
@andrewsignori-aot
#4082 - 2 Disbursement PT Schedules - Correct First Disbursement Date (…
04877ba 
…#4084)

Removed the code setting the first disbursement back for today.

### Sample application when the offering start date is ahead (2
disbursements)


![image](https://github.com/user-attachments/assets/cdf48f54-7838-457c-aa9d-240b386c17ed)

### Sample application when the offering start date is in the past (2
disbursements)


![image](https://github.com/user-attachments/assets/259e4572-449c-4baf-808b-d7d19ec7d49d)
@bidyashish bidyashish mentioned this issue Dec 12, 2024
Closed
@CarlyCotton
Copy link
Collaborator Author

@andrewsignori-aot Testing in staging and it was successful.

FYI @Joshua-Lakusta

@ninosamson
Copy link
Collaborator

Closing as complete, following staging QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsignori-aot andrewsignori-aot

@CarlyCotton CarlyCotton

Labels
Business Items under Business Consideration Ministry Ministry Features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ninosamson @andrewsignori-aot @CarlyCotton