chore(release): 2.193.0 #34309
Closed
chore(release): 2.193.0 #34309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issue # 33818 Closes #33818 #33818 ### Reason for this change Codepipeline team launched pipeline invoke action last year, but not available in cdk library yet. ### Description of changes Pipeline invoke action support ### Describe any new or updated permissions being added no ### Description of how you validated changes Unit test, local deployment, integ test. ### Checklist - [Y] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…pecified (#34245) ### Issue # (if applicable) Closes #34179 ### Reason for this change The current implementation throws an error when an IPAM pool's locale is not in the operating regions, even though locale is an optional field in CloudFormation. However, according to AWS documentation, while locale is optional, if it is specified it must be one of the operating regions. ### Description of changes - Kept the locale validation check conditional on `poolOptions.locale` being provided, since locale is an optional field - Changed the error message to be more descriptive about the requirement that locale must be configured as an operating region when specified - Maintained strict validation when locale is provided to match AWS CloudFormation's behavior where it will error if the locale is not in operating regions - Updated code comments to better reflect AWS's requirements The key design decision was to keep the error throw (rather than changing to a warning) because: 1. CloudFormation will fail if locale isn't in operating regions 2. It's better to catch this at the CDK level with a clear error message 3. This matches AWS's documented behaviour ### Describe any new or updated permissions being added No new or updated IAM permissions are required for this change. ### Description of how you validated changes The changes maintain the existing behavior when locale is provided but improve the error message clarity. No new test cases were needed as this is a refinement of error handling rather than a functional change. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes part of the checklist from the issue #34066. > Pending to add [ELBV2_ACCOUNTS](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts#L124) for this region. We will add in separate PR once the account is available for this region. ### Reason for this change register new region ### Description of changes register new region ### Describe any new or updated permissions being added N/A ### Description of how you validated changes yarn build ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…4239) ### Issue # (if applicable) None ### Reason for this change Relates to #32569 ### Description of changes Untyped Errors are not recommended. ### Describe any new or updated permissions being added None ### Description of how you validated changes Existing tests. Exemptions granted as this is a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) N/A ### Reason for this change Amazon EventBridge Pipes supports an Amazon Data Firehose delivery stream as a target. https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-pipes-event-target.html ### Description of changes Added the `FirehoseTarget` integration class. ### Describe any new or updated permissions being added Grants following actions on the target delivery stream to the pipe - `firehose:PutRecord` - `firehose:PutRecordBatch` ### Description of how you validated changes Unit tests and integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #33876 ### Description of changes LogicalId generation cover unresolved token case. ### Description of how you validated changes Unit + Integ ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…emplate (#34243) ### Issue # (if applicable) Closes NA. ### Reason for this change Placeholder link for code references are outdated in region issue template. ### Description of changes Update placeholder link and point to updated path in code repo. ### Describe any new or updated permissions being added NA ### Description of how you validated changes NA ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #34264 ### Reason for this change This change is to support the release of data source integrations for AWS AppSync Events. The implementation is almost an exact replica of the existing data sources for AppSync GraphQL APIs. ### Description of changes - New `data-source-common.ts` file which contains the data source implementation. This new file was needed given the previous `data-source.ts` implementation only works for the `IGraphqlApi` Interface. The common implementation makes it to the new generic `IApi` type is used. - Changes to `eventapi.ts` to support adding data sources to the API. - Changes to `channel-namespace.ts` to support adding event handler configuration with the data sources configured for the API. - New unit tests to validate functionality for data sources. - New integration tests to validate end-to-end functionality across all data source types and the different configurations for the Lambda data source type including direct Lambda invoke and sync/async invoke type. ### Describe any new or updated permissions being added There are no new permissions being added. The data source implementation was a copy/paste from the GraphQL implementation and the grant methods used in those have not changed in this implementation. ### Description of how you validated changes - New unit tests to validate functionality for data sources. - New integration tests to validate end-to-end functionality across all data source types and the different configurations for the Lambda data source type including direct Lambda invoke and sync/async invoke type. - `integ.appsync-eventapi-dynamodb.ts` - `integ.appsync-eventapi-eventbridge.ts` - `integ.appsync-eventapi-http.ts` - `integ.appsync-eventapi-lambda-direct-async.ts` - `integ.appsync-eventapi-lambda-direct.ts` - `integ.appsync-eventapi-lambda.ts` - `integ.appsync-eventapi-opensearch.ts` - `integ.appsync-eventapi-rds.ts` ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…troller (#34077) ### Issue # (if applicable) Closes #29707 . ### Reason for this change Currently passing in additional value to ALB helm chart is not supported. Added support for value `enableWaf` and `enableWafv2` List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199 ### Description of changes - Added new interface `AlbControllerHelmChartOptions` to support additional helm chart values - Added support for boolean type value `enableWaf` and `enableWafv2` ### Describe any new or updated permissions being added NA ### Description of how you validated changes - Added Unit test - Modified integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change Adding new team member's GitHub account ### Description of changes Adds GitHub username ### Describe any new or updated permissions being added ### Description of how you validated changes ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ue (#34288) ### Description of changes 1. Split out the part for updating the static mapping into a separate workflow which is run at 12am Monday. 2. Main workflow for actually updating the enums is set to run at 1pm Mondays and will not only rely on the existing static mapping instead of updating the static mapping before running the enum update script. 3. Also main workflow will reset all changes before creating a new PR for a separate module to fix the issue where PRs were created with combined changes from previous modules. 4. Fix open PR check by title - search for `chore(...)` instead of `feat(...)` 5. Add logging ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Description of changes fix indentation ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Description of changes change the name of the workflow for the static mapping updater ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
added
auto-approve
pr/no-squash
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
closing to accomodate PR for P0 fix |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG