-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(eks): pass additional helm chart values to aws-load-balancer-controller #34077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
7b2b36a
to
1b8a765
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
4218571
to
a014cc3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34077 +/- ##
=======================================
Coverage 84.00% 84.00%
=======================================
Files 121 121
Lines 6985 6985
Branches 1179 1179
=======================================
Hits 5868 5868
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #29707 .
Reason for this change
Currently passing in additional value to ALB helm chart is not supported.
Added support for value
enableWaf
andenableWafv2
List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199
Description of changes
AlbControllerHelmChartOptions
to support additional helm chart valuesenableWaf
andenableWafv2
Describe any new or updated permissions being added
NA
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license