Skip to content

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Apr 8, 2025

Issue # (if applicable)

Closes #29707 .

Reason for this change

Currently passing in additional value to ALB helm chart is not supported.
Added support for value enableWaf and enableWafv2
List of supported values can be verified from https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/helm/aws-load-balancer-controller/values.yaml#L199

Description of changes

  • Added new interface AlbControllerHelmChartOptions to support additional helm chart values
  • Added support for boolean type value enableWaf and enableWafv2

Describe any new or updated permissions being added

NA

Description of how you validated changes

  • Added Unit test
  • Modified integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 8, 2025 23:43
@github-actions github-actions bot added the p2 label Apr 8, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 8, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Apr 8, 2025
@shikha372 shikha372 force-pushed the shikagg/eks-alb-controller branch from 7b2b36a to 1b8a765 Compare April 9, 2025 21:28
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 9, 2025 21:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 force-pushed the shikagg/eks-alb-controller branch from 4218571 to a014cc3 Compare April 9, 2025 22:03
@shikha372 shikha372 marked this pull request as ready for review April 9, 2025 22:17
@shikha372 shikha372 assigned shikha372 and paulhcsun and unassigned shikha372 Apr 10, 2025
@paulhcsun paulhcsun changed the title feat(eks): pass additional helm chart values to aws-load-balancer-con… feat(eks): pass additional helm chart values to aws-load-balancer-controller Apr 11, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (2fac64e) to head (6f10a7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34077   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         121      121           
  Lines        6985     6985           
  Branches     1179     1179           
=======================================
  Hits         5868     5868           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 84.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 22, 2025
Copy link
Contributor

mergify bot commented Apr 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 25, 2025
Copy link
Contributor

mergify bot commented Apr 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6f10a7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6f0605b into main Apr 29, 2025
21 checks passed
@mergify mergify bot deleted the shikagg/eks-alb-controller branch April 29, 2025 04:58
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws-eks]: add support for passing helm chart values to AlbController

3 participants