Skip to content

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 21, 2025

Issue # (if applicable)

N/A

Reason for this change

Amazon EventBridge Pipes supports an Amazon Data Firehose delivery stream as a target.
https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-pipes-event-target.html

Description of changes

Added the FirehoseTarget integration class.

Describe any new or updated permissions being added

Grants following actions on the target delivery stream to the pipe

  • firehose:PutRecord
  • firehose:PutRecordBatch

Description of how you validated changes

Unit tests and integ test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 21, 2025 11:05
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 21, 2025 11:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (38d82c4) to head (bcc5e8c).
Report is 170 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33860   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 21, 2025
@Tietew Tietew changed the title feat(pipes-targets-alpha): add support for Amazon Data Firehose target feat(pipes-targets-alpha): support Amazon Data Firehose target Mar 24, 2025
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One small nit comment, but it's not critical.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 17, 2025
@Tietew
Copy link
Contributor Author

Tietew commented Apr 18, 2025

@mazyu36 Thanks!

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tietew Thanks for the contribution! Just a couple minor changes and then I'm happy to approve!

@Tietew
Copy link
Contributor Author

Tietew commented Apr 28, 2025

@paulhcsun Thanks!
I've pushed updates. But GitHub is still processing... resolved

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0292f79
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution @Tietew!

And thanks as always for the review @mazyu36!

Copy link
Contributor

mergify bot commented Apr 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ebf1ea2 into aws:main Apr 28, 2025
15 of 16 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 28, 2025
@Tietew Tietew deleted the pipes-firehose-target branch May 1, 2025 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants