-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(appsync): add support for data source integrations #34248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @garysassano - thanks for your comment. I've updated the PR comment to include your issue number for tracking. The Bedrock data source is something we can explore in a separate PR. I had reviewed it for this one but there are some gaps currently into the Bedrock module like short-hand syntax for cross-region inference profiles. The Bedrock data source in AppSync for both GraphQL and EventAPI is very simple - it's the Once this PR is merged and approved, I can start working on the other one for the bedrock method for both GraphQL and Event APIs. |
@Mergifyio update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34264
Reason for this change
This change is to support the release of data source integrations for AWS AppSync Events. The implementation is almost an exact replica of the existing data sources for AppSync GraphQL APIs.
Description of changes
data-source-common.ts
file which contains the data source implementation. This new file was needed given the previousdata-source.ts
implementation only works for theIGraphqlApi
Interface. The common implementation makes it to the new genericIApi
type is used.eventapi.ts
to support adding data sources to the API.channel-namespace.ts
to support adding event handler configuration with the data sources configured for the API.Describe any new or updated permissions being added
There are no new permissions being added. The data source implementation was a copy/paste from the GraphQL implementation and the grant methods used in those have not changed in this implementation.
Description of how you validated changes
integ.appsync-eventapi-dynamodb.ts
integ.appsync-eventapi-eventbridge.ts
integ.appsync-eventapi-http.ts
integ.appsync-eventapi-lambda-direct-async.ts
integ.appsync-eventapi-lambda-direct.ts
integ.appsync-eventapi-lambda.ts
integ.appsync-eventapi-opensearch.ts
integ.appsync-eventapi-rds.ts
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license