Skip to content

Conversation

@paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Apr 28, 2025

Description of changes

  1. Split out the part for updating the static mapping into a separate workflow which is run at 12am Monday.

  2. Main workflow for actually updating the enums is set to run at 1pm Mondays and will not only rely on the existing static mapping instead of updating the static mapping before running the enum update script.

  3. Also main workflow will reset all changes before creating a new PR for a separate module to fix the issue where PRs were created with combined changes from previous modules.

  4. Fix open PR check by title - search for chore(...) instead of feat(...)

  5. Add logging

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 28, 2025 22:54
@github-actions github-actions bot added the p2 label Apr 28, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 28, 2025
@paulhcsun paulhcsun added the pr/do-not-merge This PR should not be merged at this time. label Apr 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 28, 2025
@paulhcsun paulhcsun removed the pr/do-not-merge This PR should not be merged at this time. label Apr 28, 2025
cd tools/@aws-cdk/enum-updater
./bin/update-static-enum-mapping
- name: Check for changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step needs to move the other workflow, so we will only create a PR if there is changes to the static mapping file, or we do not need to push any prs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it is already in the other flow, so it should be removed from this one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ment this section static-mapping-check

Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Paul, I left some comments

@paulhcsun
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5758508
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aaff1f6 into aws:main Apr 29, 2025
14 of 15 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2025
@paulhcsun paulhcsun deleted the enum-updater-workflow branch April 29, 2025 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants