feat(kinesis): throw ValidationErrors instead of untyped Errors
#34239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
previously requested changes
Apr 24, 2025
|
Exemption Request: Only updated Error to ValidationErrors. |
aws-cdk-automation
added
pr-linter/exemption-requested
mazyu36
approved these changes
Apr 24, 2025
aws-cdk-automation
added
pr/needs-maintainer-review
Y-JayKim
changed the title
ValidationErrors instead of untyped ErrorsValidationErrors instead of untyped Errors
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
approved these changes
Apr 25, 2025
mrgrain
added
pr-linter/exempt-readme
mrgrain
changed the title
ValidationErrors instead of untyped ErrorsValidationErrors instead of untyped Errors
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
Relates to #32569
Description of changes
Untyped Errors are not recommended.
Describe any new or updated permissions being added
None
Description of how you validated changes
Existing tests. Exemptions granted as this is a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license