Add DbtNode.original_file_path & change file_path to property

[tatiana]

This PR is the base for supporting task groups based on dbt project subfolders (as proposed in #1566 and refactored in #2420) by simplifying the file path handling in DbtNode.

This PR introduces a new attribute, DbtNode.original_file_path, which captures the original location of a dbt node file. This attribute is somewhat redundant with the existing file_path, which can now be expressed as:

file_path (existing) = path_base (existing) + original_file_path (new)

The main goal is to streamline DbtNode properties while maintaining compatibility with both:

• Existing Cosmos workflows
• New task group support based on dbt project subfolders

Main Changes

• Introduce DbtNode.original_file_path - stores the original file path of a node
• Keep DbtNode.path_base - continues to represent the base path
  RefactorDbtNode.file_pathto a property – dynamically computed frompath_base+original_file_path`

These changes simplify path handling and make it easier to manage nodes across dbt subfolders without breaking existing functionality.

[Copilot]

Pull request overview

This PR refactors DbtNode path handling to support future task-grouping by dbt subfolders by splitting the former file_path field into path_base + original_file_path, and computing file_path dynamically.

Changes:

• Add DbtNode.original_file_path and DbtNode.path_base, and convert DbtNode.file_path into a computed property.
• Update dbt node creation in dbt ls parsing, manifest parsing, and the legacy custom parser to populate the new fields.
• Update unit tests to construct DbtNode with path_base/original_file_path and to account for the updated context_dict shape.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cosmos/dbt/graph.py	Introduces path_base/original_file_path, makes file_path computed, and updates node-building/parsing logic accordingly.
tests/test_converter.py	Updates test fixtures to build DbtNode with the new path fields.
tests/dbt/test_selector.py	Updates selector tests’ node fixtures to use path_base + original_file_path.
tests/dbt/test_pruning.py	Updates pruning tests’ node fixtures to use the new path fields.
tests/dbt/test_graph.py	Updates graph tests for the new DbtNode API and context_dict output; adjusts cache-hash assertions.
tests/airflow/test_graph.py	Updates Airflow graph tests’ node fixtures to use the new path fields.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Refactors DbtNode path handling to support future task-grouping by dbt project subfolders by introducing original_file_path and computing file_path dynamically from path_base / original_file_path.

Changes:

• Replace stored DbtNode.file_path field with path_base + original_file_path, and add file_path as a computed property.
• Update dbt parsing paths (dbt ls, manifest parsing, and custom parser) to populate the new fields.
• Update unit tests to construct DbtNode with path_base / original_file_path and adjust expected values accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cosmos/dbt/graph.py	Updates DbtNode schema and adjusts node construction in ls/manifest/custom parsing to use path_base + original_file_path.
tests/test_converter.py	Updates DbtNode fixtures to the new constructor signature.
tests/dbt/test_selector.py	Updates selector test fixtures to use path_base / original_file_path in place of file_path.
tests/dbt/test_pruning.py	Updates pruning test fixtures to use the new DbtNode path fields.
tests/dbt/test_graph.py	Updates DbtNode tests and dbt-ls parsing expectations for the new path refactor (including cache hash assertions).
tests/airflow/test_graph.py	Updates Airflow graph test fixtures to use path_base / original_file_path.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Refactors DbtNode path handling to support dbt subfolder-based task grouping by splitting the node path into a base path plus an “original” relative path, while keeping file_path available via a computed property.

Changes:

• Introduces DbtNode.path_base + DbtNode.original_file_path and refactors DbtNode.file_path into a computed property.
• Updates dbt graph loaders (dbt ls, manifest, custom parser) to populate the new path fields.
• Updates unit tests to construct DbtNode with the new path fields and adjusts expected cached hash values.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cosmos/dbt/graph.py	Refactors DbtNode path fields and updates node construction in loaders/parsers.
tests/test_converter.py	Updates DbtNode instantiation to use path_base/original_file_path.
tests/dbt/test_selector.py	Updates selector test fixtures to use the new path fields.
tests/dbt/test_pruning.py	Updates pruning test fixtures to use the new path fields.
tests/dbt/test_graph.py	Updates graph tests for new node path fields and cache-hash expectations.
tests/airflow/test_graph.py	Updates Airflow graph tests to use the new node path fields and expected node-context payloads.

Comments suppressed due to low confidence (1)

cosmos/dbt/graph.py:316

• parse_dbt_ls_output now explicitly rejects project_path=None but still advertises project_path: Path | None in its signature and raises a generic ValueError. To keep the API consistent and improve type-checking, either make project_path a required Path (and drop the runtime None-check) or keep it optional and handle None without raising. If this is a Cosmos-specific load error, consider raising CosmosLoadDbtException instead of ValueError for consistency with other load failures.

def parse_dbt_ls_output(project_path: Path | None, ls_stdout: str) -> dict[str, DbtNode]:
    """Parses the output of `dbt ls` into a dictionary of `DbtNode` instances."""
    nodes = {}
    for line in ls_stdout.split("\n"):

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Refactors dbt node path handling by splitting DbtNode.file_path into path_base + original_file_path (with file_path computed as a property), as groundwork for grouping tasks by dbt project subfolders while preserving existing behavior.

Changes:

• Introduces DbtNode.path_base and DbtNode.original_file_path, and makes file_path a computed property.
• Updates dbt parsing (dbt ls, manifest, and custom parser) to populate the new attributes.
• Updates unit tests to construct DbtNode instances with the new path attributes and to assert the new context payload.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
cosmos/dbt/graph.py	Updates DbtNode structure and adjusts parsing/building of nodes to use path_base + original_file_path.
tests/test_converter.py	Updates DbtNode test fixtures to use new path fields.
tests/dbt/test_selector.py	Updates selector-related node fixtures to use new path fields.
tests/dbt/test_pruning.py	Updates pruning-related node fixtures to use new path fields.
tests/dbt/test_graph.py	Updates graph parsing/context tests for new path fields and updated cache hash expectations.
tests/airflow/test_graph.py	Updates Airflow graph tests/fixtures to use new path fields and updated context payload assertions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

This PR refactors dbt node path handling to support future task group creation by dbt subfolder, by introducing DbtNode.original_file_path and computing DbtNode.file_path dynamically from path_base / original_file_path.

Changes:

• Add DbtNode.original_file_path and DbtNode.path_base, and convert DbtNode.file_path from a stored field to a computed property.
• Extend DbtNode.context_dict to include original_file_path while keeping file_path for compatibility.
• Update unit tests to construct DbtNode instances using path_base + original_file_path.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cosmos/dbt/graph.py	Refactors DbtNode path fields and updates dbt-ls/manifest/custom-parser node construction to use path_base + original_file_path.
tests/test_converter.py	Updates DbtNode fixtures to the new constructor fields.
tests/dbt/test_selector.py	Updates selector tests to use path_base + original_file_path in node fixtures.
tests/dbt/test_pruning.py	Updates pruning tests’ node fixtures to the new path fields.
tests/dbt/test_graph.py	Updates graph parsing/context tests for the new DbtNode API and context serialization.
tests/airflow/test_graph.py	Updates Airflow graph/task-metadata tests for the new node path handling and context payload.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.