Skip to content

Add integration test for creating a TaskGroup by dbt project folder#2420

Merged
tatiana merged 78 commits into
mainfrom
feat/create-task-groups-by-dbt-models
Mar 19, 2026
Merged

Add integration test for creating a TaskGroup by dbt project folder#2420
tatiana merged 78 commits into
mainfrom
feat/create-task-groups-by-dbt-models

Conversation

@tatiana
Copy link
Copy Markdown
Collaborator

@tatiana tatiana commented Mar 2, 2026

Follow up work to #1566, add additional tests to validate the feature:

  1. Created a dbt project called multi_folder which helps test this feature.
  2. Created and validated example DAGs both with DbtTaskGroup and DbtDag
  3. Created and validated example DAG with Watcher

dbt Project multi_folder structure:

.
├── dbt_project.yml
├── models
│   ├── models_a
│   │   ├── dim_products.sql
│   │   └── stg_products.sql
│   └── models_b
│       └── stg_regions.sql
├── profiles.yml
└── seeds
    ├── seeds_a
    │   └── products.csv
    └── seeds_b
        ├── region_managers.csv
        └── regions.csv

Visualisation of the dbt Project multi_folder via dbt docs:
Screenshot 2026-03-03 at 09 29 46

I validated the changes with the two new DAGs:

DbtDag with ExecutionMode.LOCAL
Screenshot 2026-03-03 at 09 15 26

DbtTaskGroup with ExecutionMode.LOCAL
Screenshot 2026-03-03 at 09 16 20

DbtDag with ExecutionMode.WATCHER
Screenshot 2026-03-03 at 09 26 45

maximilianoarcieri and others added 30 commits February 22, 2025 22:11
…aximilianoarcieri/astronomer-cosmos into feat/create-task-groups-by-dbt-models
…al for the user; rename variables and function
…aximilianoarcieri/astronomer-cosmos into feat/create-task-groups-by-dbt-models
@tatiana tatiana changed the title [WIP] Support creating a TaskGroup by dbt project folder Add integration test for creating a TaskGroup by dbt project folder Mar 18, 2026
@tatiana tatiana marked this pull request as ready for review March 18, 2026 22:09
@tatiana tatiana requested review from a team, corsettigyg, dwreeves and jbandoro as code owners March 18, 2026 22:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an integration-test dbt project (dev/dags/dbt/multi_folder) and new integration tests to validate Cosmos’ RenderConfig(group_nodes_by_folder=True) behavior across DbtDag, DbtTaskGroup, and Watcher execution mode.

Changes:

  • Add multi_folder dbt project fixture with multi-level models/ and seeds/ folder structure.
  • Add integration tests asserting folder-based task IDs for DbtDag and DbtTaskGroup in local execution.
  • Add integration test covering Watcher mode with group_nodes_by_folder=True and TestBehavior.AFTER_ALL.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/operators/test_watcher.py Adds Watcher-mode integration test validating folder-grouped task IDs and AFTER_ALL test task rendering.
tests/operators/test_local.py Adds local-mode integration tests for folder-grouped rendering in both DbtDag and DbtTaskGroup.
dev/dags/dbt/multi_folder/dbt_project.yml Defines the new dbt project used by the integration tests.
dev/dags/dbt/multi_folder/profiles.yml Provides a standard env-var driven dbt profile for the new project (useful for example DAGs).
dev/dags/dbt/multi_folder/models/models_a/stg_products.sql Seed-dependent model for folder-grouping coverage.
dev/dags/dbt/multi_folder/models/models_a/dim_products.sql Downstream model to validate intra-folder dependencies.
dev/dags/dbt/multi_folder/models/models_b/stg_regions.sql Model depending on multiple seeds in another folder.
dev/dags/dbt/multi_folder/seeds/seeds_a/products.csv Seed fixture for folder grouping.
dev/dags/dbt/multi_folder/seeds/seeds_b/regions.csv Seed fixture for folder grouping.
dev/dags/dbt/multi_folder/seeds/seeds_b/region_managers.csv Seed fixture for folder grouping.
dev/dags/dbt/multi_folder/.gitignore Ignores dbt build artifacts for the new project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

Comment thread tests/operators/test_local.py
@pankajkoti
Copy link
Copy Markdown
Contributor

Sorry, an afterthought, if possible, it may be a good idea to assert one of the dependencies between those tasks using depends on/ upstream tasks

@tatiana
Copy link
Copy Markdown
Collaborator Author

tatiana commented Mar 19, 2026

Sorry, an afterthought, if possible, it may be a good idea to assert one of the dependencies between those tasks using depends on/ upstream tasks

Thanks, @pankajkoti , just added this type of check in db25dde

Copilot AI review requested due to automatic review settings March 19, 2026 11:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new dbt project fixture (dev/dags/dbt/multi_folder) and new integration tests to validate Cosmos’ “group nodes by folder” rendering for both DbtDag/DbtTaskGroup (LOCAL) and DbtDag (WATCHER).

Changes:

  • Add multi_folder dbt project fixture with multi-level models/ and seeds/ subfolders.
  • Add LOCAL integration tests asserting task IDs/dependencies for folder-grouped rendering in DbtDag and DbtTaskGroup.
  • Add WATCHER integration test asserting task IDs/dependencies (and AFTER_ALL test task) for folder-grouped rendering.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/operators/test_watcher.py Adds WATCHER-mode integration test targeting group_nodes_by_folder=True with TestBehavior.AFTER_ALL.
tests/operators/test_local.py Adds LOCAL-mode integration tests for DbtDag and DbtTaskGroup with group_nodes_by_folder=True.
dev/dags/dbt/multi_folder/dbt_project.yml Defines the new multi_folder dbt project and folder-based model materialization config.
dev/dags/dbt/multi_folder/profiles.yml Adds a dbt profiles template for the new project (env-var driven).
dev/dags/dbt/multi_folder/models/models_a/stg_products.sql Adds a model depending on the products seed.
dev/dags/dbt/multi_folder/models/models_a/dim_products.sql Adds a downstream model depending on stg_products.
dev/dags/dbt/multi_folder/models/models_b/stg_regions.sql Adds a model depending on regions and region_managers seeds.
dev/dags/dbt/multi_folder/seeds/seeds_a/products.csv Adds seed data for products.
dev/dags/dbt/multi_folder/seeds/seeds_b/regions.csv Adds seed data for regions.
dev/dags/dbt/multi_folder/seeds/seeds_b/region_managers.csv Adds seed data for region_managers.
dev/dags/dbt/multi_folder/.gitignore Ignores dbt build artifacts for the new project fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread tests/operators/test_watcher.py
Comment thread tests/operators/test_local.py
@tatiana tatiana merged commit 1d33b55 into main Mar 19, 2026
76 checks passed
@tatiana tatiana deleted the feat/create-task-groups-by-dbt-models branch March 19, 2026 11:30
@pankajastro pankajastro mentioned this pull request Mar 20, 2026
pankajastro added a commit that referenced this pull request Apr 7, 2026
1.14.0 (2026-04-07)
---------------------

Breaking Changes

* Drop support for Airflow versions earlier than **2.9** by
@jedcunningham in #2288
* Fix inclusion of package models and selection/exclusion behavior by
@pankajkoti in #2357
* ``ExecutionMode.WATCHER``: The per-node ``*_status`` XCom value is now
a dict (``{"status": "<status>", "outlet_uris": [...]}``) instead of a
plain string. Any custom code that reads these internal XCom keys
directly will need to be updated by @pankajkoti in #2507

Features

* Add cluster policy support for ``ExecutionMode.WATCHER`` sensor
retries by @astro-anand in #2293
* Add debug mode to track memory utilization by @tatiana in #2327
* Add FQN selection support for ``LoadMode.DBT_MANIFEST`` by
@pankajastro in #2375
* Introduce interceptors for Cosmos tasks by @tatiana in #2419
* Add config to allow disabling dag versioning by @pankajkoti in #2470
* Implement TaskGroups by models folder by @maximilianoarcieri and
@tatiana in #1566, #2469, and #2420
* feat: implement DbtTestWatcherOperator by @michal-mrazek in #2447
* Add source freshness aware execution for ``ExecutionMode.WATCHER`` by
@pankajastro and @tatiana in #2467

* Note: Like ``ExecutionMode.WATCHER``, this feature is experimental and
its interface and implementation can change in the future.
* Add Airflow 3.2 support by @pankajastro and @pankajkoti in #2472

Enhancements

* Add watcher mode support for dbt test node states by @michal-mrazek in
#2318
* Rename watcher-mode sensor retry queue and reuse it for producer tasks
by @pankajastro in #2331
* Fix leaked semaphore warnings in Airflow 3 by resetting dbt adapters
by @pankajkoti in #2335
* Improve dbt Fusion support and related tests by @tatiana in #2356
* Default Snowflake profile mappings to four threads by @tatiana in
#2374
* Attempt to remove Pydantic as a dependency by @tatiana in #2377
* Log dbt-core and adapter versions in watcher consumer tasks by
@pankajastro in #2412
* Log model errors in watcher consumer on dbt node failure by
@pankajastro in #2431
* Reduce XCom read/write for tracking node state and errors in
ConsumerWatcher task by @pankajastro in #2471
* Remove duplicate debug log in watcher subprocess path by @tatiana in
#2494
* Simplify and unify WATCHER implementation regardless of InvocationMode
by @tatiana in #2498
* Switch to lazy imports in cosmos/__init__.py by @pankajkoti in #2531

Bug Fixes

* Handle invalid YAML errors with ``LoadMode.DBT_MANIFEST`` and
``RenderConfig.selector`` by @YourRoyalLinus in #2316
* Populate ``compiled_sql`` for ``InvocationMode.SUBPROCESS`` in
``ExecutionMode.WATCHER`` by @pankajkoti in #2319
* Fix select/exclude type mismatch by @tatiana in #2364
* Set ``emit_datasets=False`` for ``DbtTest*`` operators by @pankajastro
in #2365
* Set correct queue priority for watcher producer tasks by @pankajastro
in #2372
* Preserve ``extra_context`` for watcher consumer task instances by
@pankajkoti in #2381
* Respect ``deferrable=False`` from ``operator_args`` on watcher
consumer sensors by @pankajkoti in #2384
* Fix watcher queue precedence and add documentation by @pankajastro in
#2391
* Do not set ``compiled_sql`` on ``ExecutionMode.WATCHER`` producers by
@pankajkoti in #2440
* Remove const attribute for ``__cosmos_telemetry_metadata__`` dag param
by @pankajkoti in #2466
* Remove timeout override from Cosmos watcher sensors by @tatiana and
@claude in #2478
* Remove forced ``retries=0`` from watcher producer operators by
@tatiana in #2479
* RFC: Add patch for newer versions of amazon provider when running dbt
on EKS by @aoelvp94 in #2481
* Fix ``cosmos_debug_max_memory_mb`` XCom not pushed in Watcher sensor
tasks by @tatiana in #2503
* Fix ``TestBehavior.NONE`` and ``TestBehavior.AFTER_ALL`` exclude
ignored with selectors in ``ExecutionMode.WATCHER`` by @pankajkoti in
#2511
* Move dataset emission for ``ExecutionMode.WATCHER`` from producer to
consumer sensors by @pankajkoti in #2507

Docs

* Document cluster policy configuration for ``ExecutionMode.WATCHER``
sensor tasks by @pankajastro in #2315
* Remove outdated docs for the dbt docs plugin with Airflow 3 by
@pankajastro in #2353
* Make Watcher DBT Execution Queue heading clickable by @pankajastro in
#2354
* Update ``ExecutionMode.WATCHER`` documentation regarding test node
implementation by @jroachgolf84 in #2355
* Fix ``pre_dbt_fusion`` configuration rendering by @pankajastro in
#2369
* Add documentation for including/excluding nodes based on FQN by
@pankajastro in #2371
* Update watcher execution mode documentation by @tatiana in #2380
* Add documentation for ``DbtSeedLocalOperator`` by @jroachgolf84 in
#2383
* Fix miscellaneous Sphinx warnings by @pankajastro in #2395
* Improve contributing documentation by @lzdanski in #2397
* Add **Get Started in 5 Minutes** guide by @lzdanski in #2398
* Add Sphinx redirects package for documentation redirects by @lzdanski
in #2407
* Restructure **Getting Started** and **Guides** sections by @lzdanski
in #2418
* Add open-source quickstart by @lzdanski in #2439
* Fix documentation redirects by @lzdanski in #2442
* Restructure and refactor reference documentation by @lzdanski in #2443
* Add execution modes decision documentation by @lzdanski in #2444
* Add **Core Concepts** page to Getting Started by @lzdanski in #2448
* Add guide: *How Cosmos Works* by @lzdanski in #2449
* Update **Getting Started** overview and index pages by @lzdanski in
#2452
* Add guide: *How Cosmos Runs dbt* by @lzdanski in #2453
* Fix miscellaneous documentation links by @lzdanski in #2454
* Add Mermaid diagrams and execution mode diagrams by @lzdanski and
@tatiana in #2459
* Add documentation for memory optimization options by @pankajastro in
#2340
* Fix typo in watcher execution mode docs by @evanvolgas in #2485
* Fix minor documentation issues by @evanvolgas in #2489
* Add troubleshooting note for dbt debug logs in ExecutionMode.WATCHER
by @tatiana in #2491
* docs: unify RST header styles across documentation by @jigangz in
#2473
* docs: fix env var for rich logging by @vricciardulli in #2514
* docs: update dbt project path example for Airflow 3 Astro
compatibility by @yeoreums in #2512
* Document missing Cosmos Airflow config settings in cosmos-conf.rst by
@tatiana in #2515
* Split security-privacy policy doc and add dependency cooldown by
@pankajkoti in #2519
* Add performance optimization and troubleshooting docs by @pankajkoti
in #2521
* Update copyright year to 2026 by @tayloramurphy in #2527
* docs: Updating "Project Policies" to "Policies" in menu bar by
@jroachgolf84 in #2526

Others

* Fix tests after removing support for Airflow versions earlier than 2.9
by @tatiana in #2321
* Enable listener tests for Airflow 3.1 by @pankajastro in #2348
* Accept ``int`` or ``float`` for ``cosmos_debug_max_memory_mb`` in
integration tests by @pankajkoti in #2352
* Update ``CODEOWNERS`` to prioritize ``oss-integrations`` by @tatiana
in #2359
* Fix automatic reviewer assignment in GitHub by @tatiana and @phanikumv
in #2360
* Improve PyPI tagging by @tatiana in #2363
* Add integration tests for dbt Fusion and ``ExecutionMode.WATCHER`` by
@tatiana in #2373
* Fix Zizmor check by @tatiana in #2376
* Remove ``methodtools`` dependency by @tatiana in #2378
* Improve comments on #2389 by @evanvolgas in #2394
* Refactor ``load_from_dbt_manifest`` to reduce code complexity by
@pankajkoti in #2399
* Refactor ``_handle_no_precursors_or_descendants`` to reduce complexity
by @pankajkoti in #2400
* Improve issue templates by @tatiana in #2401
* Avoid running tests when only docs change by @tatiana in #2402
* Add ``no-reload`` target for serving docs locally by @pankajkoti in
#2405
* Fix test hash checks on macOS by @tatiana in #2406
* Attempt deterministic dbt project copy in test fixtures by @pankajkoti
in #2409
* Pin ``virtualenv <21`` due to hatch incompatibility in CI by
@pankajkoti in #2410
* Revert virtualenv pin for hatch installation in CI by @pankajkoti in
#2426
* Add version comments for commit SHA pinned GitHub Actions by
@pankajkoti in #2436
* Fix ``hatch run docs:build`` issues by @tatiana in #2437
* Minor code improvements by @dnskr in #2446
* Pre-commit autoupdate by @pre-commit-ci in #2367, #2396, #2422, #2451,
#2468, #2495, and #2516
* Add file to support Claude understanding the Cosmos repository by
@tatiana in #2458
* Dependency updates by @dependabot in #2368, #2425, #2435, #2465,
#2475, #2504, #2518, and #2528
* Isolate Scarf telemetry integration test into its own CI job by
@pankajkoti and @claude in #2477
* ci: upgrade Airflow version to 3.1 in MyPy type-check job by @yeoreums
in #2506
* Add commit message guidelines to CLAUDE.md by @pankajkoti in #2509
* Extend skipping tests in CI for more non-code file changes by
@pankajkoti in #2510
* Add Dependabot pre-commit support with 7-day cooldown by @pankajkoti
in #2517
* Enforce zero warnings policy for documentation by @dnskr in #2513

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants