Fix inclusion of package models, and selecting/excluding

[pankajkoti]

Fixes DAG rendering when using manifest load mode with installed dbt packages (e.g. Elementary, dbt_artifacts): package models are now included and have correct paths (this was not working previously).
Additionally, you can now select/exclude by package which was not working previously.
Also, fixes selecting/excluding models by folder_name which was not working previously.

Changes

Manifest mode – package nodes

• Correct file_path for package nodes: In the manifest, package nodes use original_file_path relative to the package root (e.g. models/edr/...). Cosmos now resolves them as project_path/dbt_packages/<package_name>/<original_file_path> so package models appear in the DAG and path-based logic works.
• Root vs package: Uses manifest metadata.project_name to treat root project nodes as project_path/original_file_path. When metadata.project_name is missing (older/test manifests), all nodes are treated as root for backward compatibility.
• Docs: Parsing-methods doc updated to note that package models are included when present in the manifest and that the manifest should be generated after installing and enabling packages (dbt deps then dbt compile).

Selectors

• package:package_name: You can include or exclude all nodes from a package (e.g. exclude=["package:dbt_artifacts"] or select=["package:elementary"]), including when using manifest load mode.
• Bare identifiers: A bare name with no prefix (e.g. exclude=["dbt_artifacts"]) is resolved like in dbt: by package name or node name or a folder name containing models.
• Docs and tests: Selecting-excluding doc updated with the new options and an example; tests added for select/exclude by package and bare identifier.

Robustness and errors
Empty dbt_project.yml: get_dbt_packages_subpath() no longer assumes yaml.safe_load() returns a dict; handles None (e.g. empty file) so manifest loading does not raise when the project dir has an empty dbt_project.yml.
Manifest loading: Handles json.load() returning None and uses metadata only when it is a dict when reading project_name.

closes: #1528
closes: https://github.com/astronomer/oss-integrations-private/issues/318

[netlify]

✅ Deploy Preview for astronomer-cosmos ready!

Name	Link
🔨 Latest commit	9a31652
🔍 Latest deploy log	https://app.netlify.com/projects/astronomer-cosmos/deploys/698ef7e5a1df3000089d7ca1
😎 Deploy Preview	https://deploy-preview-2357--astronomer-cosmos.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR fixes a bug where package models (e.g., from dbt_artifacts or other installed packages) could not be properly selected or excluded when using manifest load mode (LoadMode.DBT_MANIFEST). The fix adds support for the package: selector and implements dbt-like bare identifier matching.

Changes:

• Added package:package_name selector support for selecting/excluding nodes by package
• Implemented bare identifier matching (e.g., exclude=['dbt_artifacts']) that matches by package_name or node name, consistent with dbt behavior
• Fixed manifest parsing to correctly resolve file paths for package models vs. root project models
• Added defensive check in get_dbt_packages_subpath to handle non-dict YAML content

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
cosmos/dbt/selector.py	Added PACKAGE_SELECTOR constant, packages and bare_identifiers fields to SelectorConfig, implemented parsing and matching logic for package selectors and bare identifiers, refactored _handle_no_precursors_or_descendants to use dispatch pattern
cosmos/dbt/graph.py	Extracted manifest resource parsing into _parse_manifest_resources_to_nodes function, added logic to correctly resolve file paths for package models by distinguishing root project nodes from package nodes
cosmos/dbt/project.py	Added defensive isinstance check to handle cases where YAML content is not a dictionary
tests/dbt/test_selector.py	Added comprehensive tests for package selector (package:package_name), bare package name exclusion, and explicit package selection
docs/configuration/selecting-excluding.rst	Added documentation and examples for the new package: selector syntax
docs/configuration/parsing-methods.rst	Added note about package models requiring manifest regeneration after package installation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.96%. Comparing base (81b1310) to head (a28ca7f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
+ Coverage   97.93%   97.96%   +0.02%     
==========================================
  Files         102      102              
  Lines        6926     6971      +45     
==========================================
+ Hits         6783     6829      +46     
+ Misses        143      142       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tatiana]

This looks great, @pankajkoti , thanks for fixing these two issues.

As I mentioned on our call, a side-effect of this change is that the Cosmos DAG topology may change, since we were not rendering nodes that we now are. This is sometimes a side-effect of fixing issues, but could be perceived as a breaking change by some.

For this reason, I suggest we release this in 1.14.0 instead of 1.13.1 - and that we make this very explicit in the release notes in #2314 - please, raise this in that PR.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

When using graph operators with an empty package selector (e.g., select=['package:+']), the current implementation silently returns no nodes instead of raising an error. For consistency with the validation in _parse_package_selector (which raises CosmosValueError for package:), consider validating that package_selection is non-empty here and raising a CosmosValueError with a clear message if it's empty. This would provide better user feedback and prevent confusion when users accidentally use an empty package selector with graph operators.

Suggested change

	if package_selection:
	root_nodes.update(
	{node_id for node_id, node in nodes.items() if node.package_name == package_selection}
	)
	if not package_selection:
	raise CosmosValueError(
	"Empty package selector 'package:' is not allowed. "
	"Please provide a package name when using package selectors with graph operators."
	)
	root_nodes.update(
	{node_id for node_id, node in nodes.items() if node.package_name == package_selection}
	)