fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

rebenitez1802 · 2025-05-19T18:15:35Z

SUMMARY

The Issue: When auto complete shows on the screen before id is assigned to SQLEditor causes to re-render can show other autocomplete in a different position on the screen without hiding the previous one.

Solution: to disable the autocomplete feature until queryEditor.id is loaded

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

Scenarios:

Open a new query tab in SQLLab and then type something that would trigger the autocomplete
Open a saved query and then then type something that would trigger the autocomplete

Expected behavior:
For both cases autocomplete should not show, and only start showing after a the screen is fully loaded.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai · 2025-05-19T18:15:40Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

…t-able-to-dismiss

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Incorrect Temporary ID Detection Logic ▹ view	🧠 Incorrect

Files scanned

File Path	Reviewed
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/src/SqlLab/components/SqlEditor/index.tsx


  const SqlFormExtension = extensionsRegistry.get('sqleditor.extension.form');

+  const isTempId = (value: unknown): boolean => Number.isNaN(Number(value));


(cherry picked from commit b4e2406)

…he#33522)

…he#33522) (cherry picked from commit b4e2406)

(cherry picked from commit b4e2406)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: gpchandran <[email protected]> Co-authored-by: Joe Li <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Andreas Motl <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: sha174n <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Rafael Benitez <[email protected]> Co-authored-by: cccs-RyanK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <[email protected]>

added validation for temp Id

abb6e33

pull-request-size bot added the size/XS label May 19, 2025

rebenitez1802 marked this pull request as ready for review May 20, 2025 14:23

Merge branch 'apache:master' into bugfix/86405-SQLLab-Autocomplete-no…

fe57214

…t-able-to-dismiss

dosubot bot added the change:frontend Requires changing the frontend label May 20, 2025

korbit-ai bot reviewed May 20, 2025

View reviewed changes

superset-frontend/src/SqlLab/components/SqlEditor/index.tsx

const SqlFormExtension = extensionsRegistry.get('sqleditor.extension.form');

const isTempId = (value: unknown): boolean => Number.isNaN(Number(value));

This comment was marked as resolved.

Sign in to view

geido approved these changes May 20, 2025

View reviewed changes

geido merged commit b4e2406 into apache:master May 20, 2025
58 checks passed

justinpark pushed a commit that referenced this pull request May 22, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (#33522)

0ac2086

(cherry picked from commit b4e2406)

michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label May 23, 2025

michael-s-molina pushed a commit that referenced this pull request May 23, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (#33522)

a86a156

(cherry picked from commit b4e2406)

sadpandajoe pushed a commit that referenced this pull request Jun 11, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (#33522)

e6855b6

(cherry picked from commit b4e2406)

sadpandajoe added v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch labels Jun 11, 2025

sadpandajoe pushed a commit that referenced this pull request Jun 11, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (#33522)

f9f0a37

(cherry picked from commit b4e2406)

LevisNgigi pushed a commit to LevisNgigi/superset that referenced this pull request Jun 18, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apac…

5e2332c

…he#33522)

alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apac…

37f7a1a

…he#33522) (cherry picked from commit b4e2406)

sadpandajoe pushed a commit that referenced this pull request Jun 27, 2025

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (#33522)

7e05644

(cherry picked from commit b4e2406)

mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025

justinpark mentioned this pull request Aug 21, 2025

fix(sqllab): autocomplete and delete tabs #34781

Merged

9 tasks

github-actions bot added the 🍒 4.1.4 label Aug 28, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

silveira-js mentioned this pull request Jan 26, 2026

Adjust Styling Options PortalTelemedicina/superset#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

Uh oh!

rebenitez1802 commented May 19, 2025 •

edited

Loading

Uh oh!

korbit-ai bot commented May 19, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		const SqlFormExtension = extensionsRegistry.get('sqleditor.extension.form');

		const isTempId = (value: unknown): boolean => Number.isNaN(Number(value));

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

fix(Sqllab): Autocomplete got stuck in UI when open it too fast #33522

Uh oh!

Conversation

rebenitez1802 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot commented May 19, 2025

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rebenitez1802 commented May 19, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading