fix(Pivot Table): Fix column width to respect currency config #31414

Vitor-Avila · 2024-12-12T03:14:12Z

SUMMARY

Fixes #31377.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

Create a Pivot table using the cleaned_sales_data dataset.
Create a metric at the dataset level and apply a currency config.
Set country as a column, product_line as a row and use the metric created in the previous step.
Validate that the column width respects the currency config.

ADDITIONAL INFORMATION

Has associated issue: Pivot Table doesn't consider metric currency for column width #31377
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

kgabryje

Looks good!

(cherry picked from commit 43314dc)

martin-raymond · 2025-03-28T20:44:11Z

we saw a regression on all table pivot due to this fix.

The texts in cells are no longer cut if too long, and all tables with long texts in cells got horizontal scrolls bars to death

(4.1.2)

…apache#31414)" This reverts commit da4d911.

Vitor-Avila · 2025-04-01T21:37:23Z

thanks for the update, @martin-raymond. This is getting reverted in #32968

…ct currency config (#31414)" (#32968)

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

…ct currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gpchandran <poorana@gmail.com> Co-authored-by: Joe Li <joe@preset.io> Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Andreas Motl <andreas.motl@crate.io> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Yuri <yuri.bogomolov@robinhood.com> Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: sha174n <105581038+sha174n@users.noreply.github.com> Co-authored-by: Paul Rhodes <withnale@users.noreply.github.com> Co-authored-by: Rafael Benitez <rebenitez1802@gmail.com> Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <jessica.morris@cyber.gc.ca>

fix(Pivot Table): Fix column width to respect currency config

4e02b6c

pull-request-size bot added the size/XS label Dec 12, 2024

github-actions bot added the plugins label Dec 12, 2024

dosubot bot added the viz:charts:pivot Related to the Pivot Table charts label Dec 12, 2024

Vitor-Avila mentioned this pull request Dec 12, 2024

Pivot Table doesn't consider metric currency for column width #31377

Closed

kgabryje approved these changes Dec 12, 2024

View reviewed changes

Vitor-Avila merged commit 43314dc into master Dec 12, 2024
35 of 36 checks passed

rusackas deleted the fix/pivot-table-column-width branch December 12, 2024 16:51

sadpandajoe pushed a commit that referenced this pull request Dec 12, 2024

fix(Pivot Table): Fix column width to respect currency config (#31414)

da4d911

(cherry picked from commit 43314dc)

sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Dec 12, 2024

github-actions bot added 🍒 4.1.2 Cherry-picked to 4.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 24, 2025

justinpark added a commit to justinpark/superset that referenced this pull request Apr 1, 2025

Revert "fix(Pivot Table): Fix column width to respect currency config (…

ddfe186

…apache#31414)" This reverts commit da4d911.

justinpark mentioned this pull request Apr 1, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (#31414)" #32968

Merged

9 tasks

Vitor-Avila pushed a commit that referenced this pull request Apr 1, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

a36e636

…ct currency config (#31414)" (#32968)

michael-s-molina pushed a commit that referenced this pull request Apr 3, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

71b00ae

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

michael-s-molina pushed a commit that referenced this pull request Apr 14, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

6a78260

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

sadpandajoe pushed a commit that referenced this pull request May 5, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

eb2656f

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

08bf486

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

b34e2fe

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

83e3aa2

…ct currency config (#31414)" (#32968) (cherry picked from commit a36e636)

alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025

fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respe…

f8c6dda

…ct currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636)

mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025

github-actions bot added the 🍒 4.1.4 label Aug 28, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

silveira-js mentioned this pull request Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

9 tasks

silveira-js mentioned this pull request Jan 16, 2026

Fix margin parameters PortalTelemedicina/superset#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Pivot Table): Fix column width to respect currency config #31414

fix(Pivot Table): Fix column width to respect currency config #31414

Uh oh!

Vitor-Avila commented Dec 12, 2024

Uh oh!

kgabryje left a comment

Uh oh!

Uh oh!

martin-raymond commented Mar 28, 2025 •

edited

Loading

Uh oh!

Vitor-Avila commented Apr 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(Pivot Table): Fix column width to respect currency config #31414

fix(Pivot Table): Fix column width to respect currency config #31414

Uh oh!

Conversation

Vitor-Avila commented Dec 12, 2024

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

kgabryje left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

martin-raymond commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vitor-Avila commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

martin-raymond commented Mar 28, 2025 •

edited

Loading

Vitor-Avila commented Apr 1, 2025 •

edited

Loading