fix(log): store navigation path to get correct logging path

[justinpark]

SUMMARY

To determine the event source of logging, the previous patch referenced the current path using window.location. However, when navigating quickly between pages, the logging from the previous page was being processed, resulting in the event source of the previous page's logging being recorded with the current page's URL.
To resolve this issue, this commit modified the process to log the path at the time the spa_navigation event occurs, ensuring that the records during navigation are correctly attributed to the appropriate source.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

specs and screenshots

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Fix Detected
	Global Mutable State ▹ view

Files scanned

​

File Path	Reviewed
superset-frontend/src/middleware/loggerMiddleware.js	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[korbit-ai]

Global Mutable State

Tell me more

What is the issue?

The middleware uses mutable global state (lastEventId and effectively navPath) which makes the code harder to reason about and test.

Why this matters

Global mutable state can lead to unexpected behavior, makes testing difficult, and violates principles of functional programming that Redux typically encourages.

Suggested change ∙ Feature Preview

Encapsulate the state within a closure or class:

const createLoggerMiddleware = () => {
  let lastEventId = 0;
  let navPath = null;
  
  return store => next => action => {
    // middleware logic
  };
};

export default createLoggerMiddleware();

Provide feedback to improve future suggestions

💬 Looking for more details? Reply to this comment to chat with Korbit.