fix: Adds missing init file to commands/logs #33059

michael-s-molina · 2025-04-09T13:20:32Z

SUMMARY

This PR as the missing __init__.py file to commands/logs so that the folder is exported when generating the Python package.

TESTING INSTRUCTIONS

CI is sufficient.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset/commands/logs/init.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Documentation ✅

Logging ✅

Error Handling ✅

Readability ✅

Design ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

michael-s-molina · 2025-04-09T13:24:48Z

cc @landryb

codecov · 2025-04-09T13:26:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.27%. Comparing base (76d897e) to head (edd1a4e).
⚠️ Report is 2419 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33059       +/-   ##
===========================================
+ Coverage   60.48%   83.27%   +22.78%     
===========================================
  Files        1931      552     -1379     
  Lines       76236    39761    -36475     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    33110    -13004     
+ Misses      28017     6651    -21366     
+ Partials     2105        0     -2105

Flag	Coverage Δ
hive	`48.32% <ø> (-0.84%)`	⬇️
javascript	`?`
mysql	`75.46% <ø> (?)`
postgres	`75.53% <ø> (?)`
presto	`52.81% <ø> (-0.99%)`	⬇️
python	`83.27% <ø> (+19.76%)`	⬆️
sqlite	`75.03% <ø> (?)`
unit	`61.32% <ø> (+3.69%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

landryb · 2025-04-09T14:33:03Z

@michael-s-molina good catch ! successfully tested here, checked out your branch, and done the following:


/data/src/georchestra/superset-core $pip --wheel-dir=/tmp/xx wheel . 
/data/src/georchestra/superset-core $unzip -l /tmp/xx/apache_superset-0.0.0.dev0-py3-none-any.whl |grep /pru
     4078  2025-04-09 06:07   superset/commands/logs/prune.py

rusackas

Just an empty file? LGTM I guess :)

(cherry picked from commit c1159c5)

#140) the branch is rebased on top of upstream's master, ahead of 5.0.0rc2, and includes: - apache/superset#30134 (deploy under a prefix) - apache/superset#33059 (missing prune.py) - apache/superset#33060 (fix invalid query strings on role list page) assets have been rebuilt with SCARF_ANALYTICS=false in the env, thus the tracking pixel is correctly disabled (cf georchestra/superset#1)

(cherry picked from commit c1159c5)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: gpchandran <[email protected]> Co-authored-by: Joe Li <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Andreas Motl <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: sha174n <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Rafael Benitez <[email protected]> Co-authored-by: cccs-RyanK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <[email protected]>

fix: Adds missing __init__ file to commands/logs

edd1a4e

pull-request-size bot added the size/S label Apr 9, 2025

korbit-ai bot reviewed Apr 9, 2025

View reviewed changes

michael-s-molina requested review from geido, sadpandajoe and villebro April 9, 2025 13:20

michael-s-molina mentioned this pull request Apr 9, 2025

fix: Log table retention policy #32572

Merged

9 tasks

rusackas approved these changes Apr 9, 2025

View reviewed changes

michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Apr 9, 2025

michael-s-molina merged commit c1159c5 into apache:master Apr 9, 2025
52 checks passed

michael-s-molina added a commit that referenced this pull request Apr 9, 2025

fix: Adds missing __init__ file to commands/logs (#33059)

3f430ec

(cherry picked from commit c1159c5)

michael-s-molina added a commit that referenced this pull request Apr 10, 2025

fix: Adds missing __init__ file to commands/logs (#33059)

6ee902f

(cherry picked from commit c1159c5)

michael-s-molina added a commit that referenced this pull request Apr 14, 2025

fix: Adds missing __init__ file to commands/logs (#33059)

d0355d5

(cherry picked from commit c1159c5)

michael-s-molina mentioned this pull request May 16, 2025

commands/logs module missing in pypi package #33463

Closed

3 tasks

hainenber mentioned this pull request Jul 22, 2025

4.1.3: No module named 'superset.commands.logs' #34269

Open

3 tasks

sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 22, 2025

mistercrunch added 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025

sadpandajoe pushed a commit that referenced this pull request Aug 22, 2025

fix: Adds missing __init__ file to commands/logs (#33059)

174362d

(cherry picked from commit c1159c5)

github-actions bot added the 🍒 4.1.4 label Aug 28, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Adds missing init file to commands/logs #33059

fix: Adds missing init file to commands/logs #33059

Uh oh!

michael-s-molina commented Apr 9, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

michael-s-molina commented Apr 9, 2025

Uh oh!

codecov bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

landryb commented Apr 9, 2025

Uh oh!

rusackas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

fix: Adds missing __init__ file to commands/logs #33059

fix: Adds missing __init__ file to commands/logs #33059

Uh oh!

Conversation

michael-s-molina commented Apr 9, 2025

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

Uh oh!

michael-s-molina commented Apr 9, 2025

Uh oh!

codecov bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

landryb commented Apr 9, 2025

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: Adds missing init file to commands/logs #33059

fix: Adds missing init file to commands/logs #33059

korbit-ai bot left a comment •

edited

Loading

codecov bot commented Apr 9, 2025 •

edited

Loading