fix: improve error type on parse error #33048

justinpark · 2025-04-08T23:45:53Z

SUMMARY

When sql_parse encounters a SupersetParseError, the logged error_type is recorded as QUERY_SECURITY_ACCESS_ERROR, which is ambiguous. This commit updates the error_type to INVALID_SQL_ERROR for clarity.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Run a invalid sql that causes the sql_parse error like SELECT * FROM table LIMIT 100'

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset/sql_parse.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Documentation ✅

Logging ✅

Error Handling ✅

Readability ✅

Design ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

codecov · 2025-04-08T23:51:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.27%. Comparing base (76d897e) to head (609b1a8).
⚠️ Report is 2419 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33048       +/-   ##
===========================================
+ Coverage   60.48%   83.27%   +22.78%     
===========================================
  Files        1931      552     -1379     
  Lines       76236    39761    -36475     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    33110    -13004     
+ Misses      28017     6651    -21366     
+ Partials     2105        0     -2105

Flag	Coverage Δ
hive	`48.32% <ø> (-0.84%)`	⬇️
javascript	`?`
mysql	`75.46% <ø> (?)`
postgres	`75.53% <ø> (?)`
presto	`52.81% <ø> (-0.99%)`	⬇️
python	`83.27% <ø> (+19.76%)`	⬆️
sqlite	`75.03% <ø> (?)`
unit	`61.37% <ø> (+3.74%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

michael-s-molina · 2025-04-09T11:13:21Z

@betodealmeida You probably have more context on why this was a security exception previously so I'll wait for your review.

betodealmeida · 2025-04-09T12:32:30Z

superset/sql_parse.py

            raise SupersetSecurityException(
                SupersetError(
-                    error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR,
+                    error_type=SupersetErrorType.INVALID_SQL_ERROR,


Thanks! The intent here was that we often need to extract tables in order to see if a query can run, but obviously we do for other reasons. Potentially we could add a try/except in the security manager to capture this error and convert it to a security error, but I don't think it's necessary.

(cherry picked from commit ed0cd5e)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: gpchandran <[email protected]> Co-authored-by: Joe Li <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Andreas Motl <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: sha174n <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Rafael Benitez <[email protected]> Co-authored-by: cccs-RyanK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <[email protected]>

fix: improve error type on parse error

609b1a8

pull-request-size bot added the size/XS label Apr 8, 2025

justinpark requested a review from betodealmeida April 8, 2025 23:46

korbit-ai bot reviewed Apr 8, 2025

View reviewed changes

justinpark requested a review from michael-s-molina April 8, 2025 23:49

betodealmeida approved these changes Apr 9, 2025

View reviewed changes

justinpark merged commit ed0cd5e into apache:master Apr 9, 2025
50 checks passed

justinpark added v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch labels Apr 9, 2025

justinpark added a commit that referenced this pull request Apr 9, 2025

fix: improve error type on parse error (#33048)

20f36cd

(cherry picked from commit ed0cd5e)

michael-s-molina pushed a commit that referenced this pull request Apr 9, 2025

fix: improve error type on parse error (#33048)

db2f8c2

(cherry picked from commit ed0cd5e)

michael-s-molina pushed a commit that referenced this pull request Apr 14, 2025

fix: improve error type on parse error (#33048)

e0e2d32

(cherry picked from commit ed0cd5e)

sadpandajoe pushed a commit that referenced this pull request May 5, 2025

fix: improve error type on parse error (#33048)

7194167

(cherry picked from commit ed0cd5e)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix: improve error type on parse error (#33048)

48738a3

(cherry picked from commit ed0cd5e)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix: improve error type on parse error (#33048)

efc81ff

(cherry picked from commit ed0cd5e)

sadpandajoe pushed a commit that referenced this pull request May 6, 2025

fix: improve error type on parse error (#33048)

df8109f

(cherry picked from commit ed0cd5e)

mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025

github-actions bot added the 🍒 4.1.4 label Aug 28, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: improve error type on parse error #33048

fix: improve error type on parse error #33048

Uh oh!

justinpark commented Apr 8, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

codecov bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

michael-s-molina commented Apr 9, 2025 •

edited

Loading

Uh oh!

betodealmeida Apr 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

fix: improve error type on parse error #33048

fix: improve error type on parse error #33048

Uh oh!

Conversation

justinpark commented Apr 8, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

Uh oh!

codecov bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-s-molina commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

betodealmeida Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

korbit-ai bot left a comment •

edited

Loading

codecov bot commented Apr 8, 2025 •

edited

Loading

michael-s-molina commented Apr 9, 2025 •

edited

Loading