fix: Saved queries list break if one query can't be parsed #34289

michael-s-molina · 2025-07-23T18:58:42Z

SUMMARY

If a saved query can't be parsed by SQL Glot to extract the table names, the whole listing page breaks with the following error:

An error occurred while fetching Saved queries: list index out of range

Fixes #34019.

TESTING INSTRUCTIONS

Save a query.
Edit the query with invalid SQL.
Go to the saved queries list.
The list should render normally and the problematic SQL should have nothing in the Tables column.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

michael-s-molina · 2025-07-23T18:59:02Z

Tagging @betodealmeida @dpgaspar for security review.

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset/models/sql_lab.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

codecov · 2025-07-23T19:04:30Z

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (c444eed) to head (8b0e69f).
⚠️ Report is 1030 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/models/sql_lab.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #34289       +/-   ##
===========================================
+ Coverage        0   72.95%   +72.95%     
===========================================
  Files           0      561      +561     
  Lines           0    40622    +40622     
  Branches        0     4273     +4273     
===========================================
+ Hits            0    29634    +29634     
- Misses          0     9867     +9867     
- Partials        0     1121     +1121

Flag	Coverage Δ
hive	`47.16% <50.00%> (?)`
mysql	`71.94% <50.00%> (?)`
postgres	`71.99% <50.00%> (?)`
presto	`50.92% <50.00%> (?)`
python	`72.91% <50.00%> (?)`
sqlite	`71.53% <50.00%> (?)`
unit	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

betodealmeida

Looks good! Can we add a test to make sure it works?

michael-s-molina · 2025-07-23T19:44:46Z

Looks good! Can we add a test to make sure it works?

Done!

(cherry picked from commit 1e5a4e9)

)

(cherry picked from commit 1e5a4e9)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <[email protected]> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: gpchandran <[email protected]> Co-authored-by: Joe Li <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Andreas Motl <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Yuri <[email protected]> Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: sha174n <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Rafael Benitez <[email protected]> Co-authored-by: cccs-RyanK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <[email protected]>

fix: Saved queries list break if one query can't be parsed

ec469a4

michael-s-molina requested review from betodealmeida and dpgaspar July 23, 2025 18:58

pull-request-size bot added the size/XS label Jul 23, 2025

dosubot bot added the sqllab:saved_queries label Jul 23, 2025

korbit-ai bot reviewed Jul 23, 2025

View reviewed changes

betodealmeida approved these changes Jul 23, 2025

View reviewed changes

Add tests

fc99707

pull-request-size bot added size/M and removed size/XS labels Jul 23, 2025

Fix mypy error

8b0e69f

michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Jul 24, 2025

michael-s-molina merged commit 1e5a4e9 into apache:master Jul 24, 2025
56 checks passed

michael-s-molina added a commit that referenced this pull request Jul 24, 2025

fix: Saved queries list break if one query can't be parsed (#34289)

1926e90

(cherry picked from commit 1e5a4e9)

sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 24, 2025

LisaHusband pushed a commit to LisaHusband/superset that referenced this pull request Aug 17, 2025

fix: Saved queries list break if one query can't be parsed (apache#34289

627d328

)

dankor pushed a commit to dankor/superset that referenced this pull request Aug 18, 2025

fix: Saved queries list break if one query can't be parsed (apache#34289

305903a

)

sadpandajoe pushed a commit that referenced this pull request Aug 22, 2025

fix: Saved queries list break if one query can't be parsed (#34289)

d75e9d5

(cherry picked from commit 1e5a4e9)

github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 4.1.4 labels Aug 28, 2025

github-actions bot added the 🚢 6.0.0 First shipped in 6.0.0 label Dec 18, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Saved queries list break if one query can't be parsed #34289

fix: Saved queries list break if one query can't be parsed #34289

michael-s-molina commented Jul 23, 2025

Uh oh!

michael-s-molina commented Jul 23, 2025

Uh oh!

korbit-ai bot left a comment

Uh oh!

codecov bot commented Jul 23, 2025 •

edited

Loading

Uh oh!

betodealmeida left a comment

Uh oh!

michael-s-molina commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Saved queries list break if one query can't be parsed #34289

fix: Saved queries list break if one query can't be parsed #34289

Conversation

michael-s-molina commented Jul 23, 2025

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

michael-s-molina commented Jul 23, 2025

Uh oh!

korbit-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

betodealmeida left a comment

Choose a reason for hiding this comment

Uh oh!

michael-s-molina commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 23, 2025 •

edited

Loading