fix(list roles): dont send invalid querystrings #33060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appeases java apps proxying superset modeled after the query listing roles done by the same page, eg: /api/v1/security/roles/search/?q=(order_column:name,order_direction:desc,page:0,page_size:25)
9 tasks
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unsafe URL Parameter Interpolation ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/pages/RolesList/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
Comment on lines
164
to
169
| const fetchPage = async (pageIndex: number) => { | ||
| const response = await SupersetClient.get({ | ||
| endpoint: `api/v1/security/users/?q={"page_size":${pageSize},"page":${pageIndex}}`, | ||
| endpoint: `api/v1/security/users/?q=(page_size:${pageSize},page:${pageIndex})`, | ||
| }); | ||
| return response.json; | ||
| }; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
i'm pretty sure the above automated review feedback also applied to the previously existing code, so i'm not going to take it into account...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
landryb
added a commit
to georchestra/ansible
that referenced
this pull request
Apr 10, 2025
#140) the branch is rebased on top of upstream's master, ahead of 5.0.0rc2, and includes: - apache/superset#30134 (deploy under a prefix) - apache/superset#33059 (missing prune.py) - apache/superset#33060 (fix invalid query strings on role list page) assets have been rebuilt with SCARF_ANALYTICS=false in the env, thus the tracking pixel is correctly disabled (cf georchestra/superset#1)
michael-s-molina
added
v5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appeases java apps proxying superset
modeled after the query listing roles done by the same page, eg:
/api/v1/security/roles/search/?q=(order_column:name,order_direction:desc,page:0,page_size:25)SUMMARY
with #32432, two queries sent by the react page are invalid urls and confuse a java-based proxy.
cf #32432 (comment) and georchestra/superset#13
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION