ci: allow glamr-agent to request CI on its own unsigned PRs

[MatejKosec]

GLAMR creates unsigned commits, so the signature check blocked its full-CI requests. This change lets glamr-agent request CI on its own fork PRs without signing those commits.

The commenter, PR author, and head repository owner must all have GitHub account ID 282374502, and the request must name the full SHA of the PR's current head. The workflow still rejects stale requests and avoids duplicate approvals. Automatic approvals for maintainers and approved external contributors still require verified signatures.

All 20 local checks passed using the workflow's shell steps with mocked GitHub responses. They cover unsigned GLAMR requests, account mismatches, another account's fork, missing fork ownership, stale commits, duplicate approvals, and the signature requirements for other automatic approvals. Repository pre-commit checks also passed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1de910c3-0388-4f17-8aa4-cff90253e2ea

📥 Commits

Reviewing files that changed from the base of the PR and between 18a75aa and 0a2ec50.

📒 Files selected for processing (2)

• .github/workflows/trigger-ci-approval-flow.yml
• AGENTS.md

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The workflow now recognizes qualifying GLAMR approval requests for fork pull requests. These requests bypass commit-signature verification. Other approval paths retain signature verification requirements.

Changes

GLAMR CI approval

Layer / File(s)	Summary
Approval path contract .github/workflows/trigger-ci-approval-flow.yml, AGENTS.md	The documented approval paths now require GLAMR identity, pull request authorship, and head-SHA matching for the GLAMR exception. The repository rules describe the same signature-verification exception.
Conditional approval enforcement .github/workflows/trigger-ci-approval-flow.yml	The workflow checks the fork pull request author for GLAMR requests, skips commit-signature verification for valid GLAMR approvals, and posts /ok to test when either the request or required signatures are valid.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0a2ec

The GLAMR approval flow is constrained to authenticated matching identities and the current fork-PR head, with no actionable merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the implementation, validation rules, preserved safeguards, and test coverage. However, it does not use the required template sections and omits the required Related Issues se…	Add the required Overview, Details, Where should the reviewer start?, and Related Issues sections. In Related Issues, either provide a valid issue reference or confirm that the pull request is not linked to an issue.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: allowing glamr-agent to request CI for its own unsigned pull requests.

Full details: Description check

Explanation

The description explains the implementation, validation rules, preserved safeguards, and test coverage. However, it does not use the required template sections and omits the required Related Issues section, including confirmation that no issue is linked or a valid issue reference.

• Fix all pre-merge checks with AI

---

_{Comment @coderabbitai help to get the list of available commands.}

[dmitry-tokarev-nv]

Review

The change does what the title says. One low-severity scoping note below. No blocking findings.

What I checked, and how

Identity. The commenter check is github.event.comment.user.id == 282374502 in the job if:. GitHub sets that field, so a display name or a comment body cannot fake it. The new line at trigger-ci-approval-flow.yml:86 adds the same account ID check on the pull request opener. gh api users/glamr-agent returns id 282374502, type User.

Trigger. This path runs on issue_comment with type created only. An edit to an existing comment does not fire it. The pull_request_target path is untouched and still requires verified signatures on every commit in the recorded base-to-head range.

What it unlocks. The workflow posts /ok to test <full-sha> with secrets.AUTO_VERIFIER_CI_TOKEN. copy-pr-bot then creates pull-request/N, which starts pr.yaml on the self-hosted prod-builder-amd-v1, prod-tester-amd-v2, prod-tester-arm-v2 and prod-deploy-tester-v1 runners. That chain reads AZURE_ACR_*, DOCKERHUB_*, AWS_* and HF_TOKEN. So the exemption decides whether unsigned fork code runs on those runners.

Scope. Two shapes tested by execution, in the folded evidence of the inline comment. A request on another account's pull request is blocked. A request on a pull request that glamr-agent opened from another account's fork is not blocked.

Step references. I parsed the file with a YAML parser. All eleven steps.<id>.outputs.<name> references resolve to a real step id and to an output that some step writes, so no condition silently renders empty.

Siblings. No other workflow in .github/workflows/ posts /ok to test or checks commit signatures, so no sibling is missing this exemption or wrongly carrying it.

Not verified. The pull request body reports 16 local checks with mocked GitHub responses. Those checks are not committed, so I could not run them. I wrote my own harness instead.

Both earlier review-bot comments asked to delete redundant inline narration. The author removed both, in 5df3a34 and 8857148.

[dmitry-tokarev-nv]

Approving. Zero P0 and zero P1 findings. One P3 remains open: the glamr-agent "own pull request" check reads the pull request opener and not the head repository owner, so a pull request that glamr-agent opens from another account's fork also skips the signature step. That is a hardening ask, not a blocker.

I verified by execution that the commenter and opener checks both key on GitHub account ID 282374502, which is glamr-agent and which a rename cannot move; that the trigger is issue_comment with type created only, so an edited comment does not fire it; that a request on somebody else's pull request is rejected; that a stale SHA is rejected; and that the pull_request_target paths still require a verified signature on every commit. A YAML parse confirms every steps.<id>.outputs.<name> reference resolves.

Not verified: the 16 local checks named in the pull request body are not committed, so I ran my own harness instead. I also did not test whether GitHub accepts a pull request whose head branch sits in a repository the opener cannot push to.

[dmitry-tokarev-nv]

Re-approved at 476522d3 on 2026-09-17. My earlier approval covered 8857148b, and this head is two commits ahead.

The new work closes the P3 on the exemption predicate. I re-ran the round-one case matrix against each tree instead of reading the diff. One case moved, and it moved toward rejection.

Measured: predicate delta, case matrix, and output-reference resolution at 476522d

The exemption predicate gained one conjunct and lost nothing. Before, it reached "the agent opened the pull request". After, it reaches "the agent opened the pull request and the agent owns the head repository". The added check reads .head.repo.owner.id, a numeric account ID, so a login rename cannot satisfy it. The commenter check in the job condition and the PR opener check are also numeric account IDs.

case	at 8857148	at 476522d
agent opener, agent-owned head	allowed	allowed
agent opener, third-party head	allowed	rejected
third-party opener, agent comments	rejected	rejected
third-party opener, agent-owned head	rejected	rejected
stale SHA in the comment	rejected	rejected
text after the SHA	rejected	rejected
push event, agent PR	signature step runs	signature step runs
push event, other PR	signature step runs	signature step runs

Absent owner data, an account ID that only shares a prefix, and a matching login with a different account ID are all rejected.

The last commit only moves the account ID into a step env value. Every cell of the matrix is identical across it. The comparison keeps the variable in double quotes, so the shell does not treat the value as a pattern, and an unset value rejects the request.

All 30 steps.<id>.outputs.<name> references in the file resolve to a real step ID and a real output name, so none of them renders empty.

The pull request text and the workflow header match the code.

No open findings from me. The readability request on the account ID literal is now addressed in the code.