fix(ci): Use pytest --ignore to Skip Tests Based on Framework

[whoisj]

Overview:

This change uses the inputs.framework value to determine if specific tests should be skipped.
This is useful as specific tests will automatically fail due to dependencies missing in the containers for specific frameworks.

Thanks to @kthui for the recommendation.

Details:

Removes previous explicit import failure => ignore logic which could hide actual errors in non-Triton frameworks.

🚫 This PR is NOT linked to an issue:

• Confirmed — no related issue

Summary by CodeRabbit

• Tests
  • Updated continuous integration test selection to apply framework-specific exclusions while retaining tracing options.
  • Adjusted fault-tolerance and serving test suites so they run without automatically skipping entire modules when PyTorch is unavailable.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 55cd327c-f9e1-4a37-8f5c-75242fcc5b6a

📥 Commits

Reviewing files that changed from the base of the PR and between 038d6f2 and 12a0441.

📒 Files selected for processing (5)

• .github/workflows/shared-test.yml
• tests/fault_tolerance/test_canary_rank_pause.py
• tests/serve/test_sglang.py
• tests/serve/test_trtllm.py
• tests/serve/test_vllm.py

💤 Files with no reviewable changes (4)

• tests/serve/test_sglang.py
• tests/serve/test_vllm.py
• tests/fault_tolerance/test_canary_rank_pause.py
• tests/serve/test_trtllm.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The change removes module-level Torch-based skips from four test modules. Shared CI test options now retain --ddtrace and exclude incompatible test paths based on inputs.framework.

Changes

Test Collection and Framework Routing

Layer / File(s)	Summary
Remove module-level Torch skips tests/fault_tolerance/test_canary_rank_pause.py, tests/serve/test_sglang.py, tests/serve/test_trtllm.py, tests/serve/test_vllm.py	The test modules no longer skip all tests when Torch is unavailable.
Add framework-specific pytest exclusions .github/workflows/shared-test.yml	PYTEST_ADDOPTS retains --ddtrace and adds conditional ignore paths for Triton and non-Triton test runs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 12a04

The CI routing change has no established current-head failure or merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description explains the framework-based test skipping and the removal of explicit import-failure handling. It includes the Overview, Details, and required Related Issues sections. It does not inc…
Title check	✅ Passed	The title clearly summarizes the main CI change: using pytest --ignore to skip tests based on the framework.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[whoisj]

/ok to test d7079d6

[dmitry-tokarev-nv]

Intent, from the diff and the PR body: move the "this file cannot be imported on the Triton image" decision out of four test modules and into shared-test.yml, so a genuine ModuleNotFoundError in those files stops being swallowed by a try: import torch guard.

pytest --ignore is a collection-time exclusion that leaves no trace in the result count, so I established the executed set on both sides rather than reading it off the diff.

No test silently stopped running

Triton lane (framework == 'triton'; pr.yaml:936 and post-merge-ci.yml:639 are its only callers, both through this workflow, so nothing runs the Triton image outside this PYTEST_ADDOPTS):

	passed	skipped	total
base — main 165fca70, post-merge triton-runtime / CPU Test	117	28	145
head — this PR, pre-merge triton-runtime / CPU Test	117	24	141

Same 117 passes. The 4-record delta is exactly the four module-level skips this PR deletes — base logs SKIPPED [1] tests/serve/test_vllm.py:19: torch not available in this image and its three siblings, head logs none of them. From the -v output the lane collects exactly the eight components/src/dynamo/triton/tests/test_triton_*.py files plus tests/frontend/grpc/test_triton_identity.py, on both sides.

Non-Triton lanes. The dynamo-framework CPU jobs are the only ones whose marker expression (... and not (vllm or sglang or trtllm) ...) can select triton-marked tests. Base collected 5751, head 5699. Rather than trust the counts I diffed the executed node IDs: all 52 are in components/src/dynamo/experimental/tests/test_llm.py (18), components/src/dynamo/frontend/tests/test_jemalloc.py (13), components/src/dynamo/experimental/tests/test_endpoint.py (9), lib/bindings/python/tests/* (11) and benchmarks/router/tests/test_aiperf_commands.py (2) — tests main gained in the 37 commits after this PR's merge base, not anything the new --ignores removed. Neither newly-ignored path appears in the executed set on either side. Collection errors: 0 on both. planner also passes framework: dynamo, but its image's /workspace has no tests/serve/ at all, so it is untouched either way.

The mechanics hold

Parsing the folded scalar and substituting the expressions yields --ddtrace --ignore=… --ignore=…\n with runs of blanks; pytest shlex.splits PYTEST_ADDOPTS, so the blanks and the trailing newline disappear. On pytest 9.0.3 (the version in the CI image), from the cwd the action actually uses (cd /workspace, rootdir: /workspace), against a tree mirroring these paths: all six relative paths resolve, and --ignore=components/src/dynamo/triton/tests/ does exclude the directory despite the trailing slash. I also confirmed the failure mode this class of change usually hides — --ignore on a non-existent path is completely silent, no warning, exit 0 — and checked all six against the tree at head; none is stale.

tests/fault_tolerance/test_canary_rank_pause.py is the only importer of the three now-unguarded tests/serve/test_* modules, and it is itself in the ignore list, so the set is closed.

Three P3 notes inline, all non-blocking.

---

Approved. Zero P0/P1; three P3 notes above, none blocking. Deliberately deferred: the --ignore list is maintained by hand and will need re-checking if any of those four files moves — noted inline rather than held against this PR. I authored no commits on this PR.

[whoisj]

/ok to test 466010e