Merged
Conversation
* Adds dev dependency on opn for opening browsers and other things. * Adds a --open option to cli to open browser window. * Removes unused variable in index. * Adds opn types to dev dependencies from definitely typed. * Adds open to the cliArgs type to allow for consistency. * Updates snapshots that require valid cliArgs types. * Moves opn to direct dependency since its used in cli. * [cli] move --open handling to cluster manager * Adds support for running --open with --no-base-path
## Summary (fixes #25342) There is a fatal when using the File Upload control in the image upload control. While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page. I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly. @rashidkpc agreed this would be a good fix for the moment. In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button. ## Test Plan Added a `setTimeout` call to simulate load. Toggled between data url and literal URL.  - Before  - After  - Fixed Warning  ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ ~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
* fix: proptype error * fix: correct proptype checking * fix: add assets placeholder to initial state * chore: add history formatting function * fix: load workpad assets when ids change this causes the correct assets to be used
* typescriptin a few ui/public * remove mistaken commits * typescript numeric * ts migrateLegacyQuery * object or string type * no need for file extension on import statement * revert mistaken commit * type fix - only object * snake case!
* update EUI to v5.0.0 * update snapshots * revert snapshot change * revert snapshot change (2)
* [APM] Fix Rison issues * Fix CI * Removed abstractions (and broke tests) * Slight rework and small bugfix for query param handling * Removed typo used for visibility testing oops * Removes unused dep because linting doesnt work apparently
* [DOCS] Adds early draft of Canvas docs * [DOCS] Added images and beta label to Canvas docs
* Add more details for debugging Kibana server * add debugging server code to table to contents
* [ML] Confirm Modal Controller Test. * [ML] Message Bar Controller test. * [ML] Data Visualizer Controller test. * [ML] Detector Filter Modal Controller test. * [ML] Detector Modal Controller test. * [ML] Save Status Modal Controller test. * [ML] Multi Metric Create Job Controller test. * [ML] Population Create Job Controller test. * [ML] Recognize Create Job Controller test. * [ML] Single Metric Create Job Controller test. * [ML] Index Or Search Controller test. * [ML] Job Type Controller test. * [ML] Angular Bootstrap Patch Dropdown Controller test. * [ML] Settings Controller test. * [ML] Calenders List Controller test. * [ML] New Event Modal Controller test. * [ML] New Event Modal Controller test. * [ML] Create Calendar Controller test. * [ML] Time Series Explorer Controller test. * [ML] Fixes typo, clearer test name. * [ML] Fixes tests by restoring stubs.
* [ML] Updates job type and APM module icon to new designs * [ML] Use self closing tags for icons * [ML] Removes unnecessary icon from jobs list
* [APM] Format as microseconds * Split interface into `value` and `options` * Update formatters.test.ts
* [APM] Minor cleanup of constants * Simplify constants test
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
… whitelisting devOnly licenses (#23859) * chore(19834): upgraded yargs dependency to 4.8.1 in order to remove pkg-conf dependency license conflict. * chore(19834): override xmldom to one of the allowed licenses (MIT). * chore(19834): added some overrides and whitelistenig for Apache2. * chore(19834): correct overides for some apache2 licenses. * chore(NA): updated specific dependency needs. * chore(19834): added some more info on updated licenses. * chore(19834): small note on dependencies use versions. * feat(NA): add the ability to white list licenses only valid for dev only dependencies. * chore(NA): update yarn lock files to include integrity check. * fix(NA): yarn lock file for kbn ui framework. * docs(NA): fix uncompleted comment left on the code.
* edits to canvas getting started docs * edit to canvas workpad docs
SQL requires that you quote the index name if you are using special characters (like *, with an index pattern). Our default value didn't work since `logstash*` was not quoted. ### Before  ### After  ...and if you select some valid fields so you don't get an array in the results: 
I noticed some discussion about how kbn clean should probably clear out the `.eslintcache` file, since it doesn't handle changes in related modules (for things like the import plugin) and it would be nice if `yarn kbn clean` took care of the issue. I figured it's not a bad idea, but adding `.eslintcache` directly to `@kbn/pm` felt wrong, so instead I've added another config options that can go in the package.json file, `clean.extraPatterns`. This array of patterns is passed into `del()` so that it can include things like negation. As the name suggests this doesn't override the initial paths, just adds some extras that will be checked and cleared when `yarn kbn clean` is run.
* feat(NA): extend support from precommit hook to git GUI apps. * docs(NA): more descriptive error message.
Fixes #26295 There are several places where we have accidentally added new license headers with linters but failed to remove old license headers manually. This prevents that by applying the an inverted version of the license headers rule that removed invalid license headers when files are moved.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* chore(NA): cherry pick work from spencer on impleting the cache invalidation system and merging it with current master. * feat(NA): add support for dlls bundle into the cache state invalidation system. * chore(NA): merge with master. * feat(NA): first working version for the watch cache. * feat(NA): added logger, correct cache delete and removed last todos. * feat(NA): remove some useless features for the time being. * refact(NA): just pass kibanaHapiServer.log function directly instead of an anonimous function that calls the kibanaHapiServer.log one. * refact(NA): move everything to async. * refact(NA): remove dll mentions. * chore(NA): removed types/mkdirp as we dont use mkdirp into typescript.
* Feature: POST only once even when updating multiple Canvas elements * Chore: remove disused action
* Decuple the UI setting config from kbn-es-query package * Remove BuildESQueryProvider on ml utils
* [APM] Move ML anomaly transformation to backend Move apmTimeseries to backend Fix tests * Update default values * Fix bug
Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query Fix tests Remove unused aggregation Revert "Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query" This reverts commit 5aa86744a0b360ceb75a59ebc8a0a084b24fbe50.
…l typings file (#26160) * docs(Typescript): Update doc to put eui typings in global typings file * Update TYPESCRIPT.md Co-Authored-By: sebelga <sabee77@gmail.com> * Update Typescript.md
* [APM] Get rid of `pre` middleware * Add `search_fields=title`
* [Reporting] A few more error handling improvements * update comment * Update index.js link another api documentation site in a comment
* Fix auto refresh after page reload * Fix timefilter initial state
Closes #16796 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Removes event-stream package (and sub-deps) + implements a similar API to what we were using * Removing array_streams in favor of existing utils * Fixing lockfile * Allow report-errors to propogate through (don't catch) * [cli/reloacConfig/test] update test to use promises * avoid mixing async and Promise.then more than necessary
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
* [kbn/i18n] remove npm-run-all * remove unnecessary package * loop through babel sub tasks and use helper for task name padding * add --source-maps flag * update yarn.lock
Cleanup some of the legacy bits from our ci_setup, simplify the setup necessary in child CI scripts, and unify the more generic bits of the scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.