Fix: Run with reporting disabled#25829
Conversation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
|
Why is the error message calling out Chromium instead of the enabled/disabled setting? Just might be confusing since chromium is the default now, so they shouldn't actually have to add that, just make sure it's not set to phantom, and make sure it's not disabled. |
|
@stacey-gammon yeah, I was thinking about that too. Planning to make a follow-on PR that shows a different message when Reporting is just disabled. Opened #26357 to track it. |
clintandrewhall
left a comment
There was a problem hiding this comment.
Just FYI: your test plan states one should
set
xpack.reporting.disabled
That threw an error for me. Did a quick search, found it was xpack.reporting.enabled: false. :-)
Otherwise, all went well. Apologies for my delay in review...!
|
@clintandrewhall I really should proof-read what I write I guess, heh. Thanks for the review. |
0a1196f to
50cff8d
Compare
the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
|
Quick refactor and addition after testing on master. It was broken there too, in a different way, thanks to code duplication (as mentioned in #26375). Was seeing this error: |
💚 Build Succeeded |
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix
* fix: relative link instead of static * fix: handle missing reporting config value * chore: refactor reportingBrowserType check * fix: core interpreter reportingBrowserType the code was duplicated from canvas, so it's equally as broken, this duplicates the fix

Closes #25728
Fixes reporting import and config checking.
pluginsaliasconfig.getso it doesn't throw when reporting is disabledTo test, simply set
xpack.reporting.enabled: falsein your kibana.yml. Previously, it would fail to build, and crash the server even if it would.