Removes event-stream package#26205
Merged
joelgriffith merged 7 commits intoelastic:masterfrom Nov 28, 2018
joelgriffith:chore/remove-event-stream
Merged
Removes event-stream package#26205joelgriffith merged 7 commits intoelastic:masterfrom joelgriffith:chore/remove-event-stream
joelgriffith merged 7 commits intoelastic:masterfrom
joelgriffith:chore/remove-event-stream
Conversation
joelgriffith
requested review from
bevacqua,
joshdover,
spalger and
stacey-gammon
joelgriffith
commented
Nov 26, 2018
joelgriffith
commented
Nov 26, 2018
bevacqua
approved these changes
Nov 26, 2018
Contributor
💔 Build Failed |
spalger
reviewed
Nov 26, 2018
spalger
reviewed
Nov 26, 2018
Contributor
💔 Build Failed |
Contributor
|
is this just the package related to this report? |
Contributor
|
@guanghaofan yes, this is removing all usage of the problematic package. The backdoor that the package introduced doesn't affect Kibana, and the version which we're using doesn't have the backdoor, but given the current state of the matter, we determined it'd be safest to remove all usages. |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
🎉 Thanks Spencer! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event-stream has some bad sub-dependencies covered in their current semver range (more here). Though we don't load this bad range, and given the nature of the comments on this issue, I would feel better if we didn't require this package anywhere. This PR does that.
Given that I'm not an expert in either of these area, I'd appreciate thorough review since it's outside of my current knowledge-base of Kibana.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately