[APM] Get rid of pre middleware#26256
Merged
sorenlouv merged 1 commit intoelastic:masterfrom Nov 28, 2018
Merged
Conversation
Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query Fix tests Remove unused aggregation Revert "Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query" This reverts commit 5aa86744a0b360ceb75a59ebc8a0a084b24fbe50.
sorenlouv
commented
Nov 27, 2018
| } | ||
| } | ||
| } | ||
| sort: [{ [SPAN_START]: { order: 'asc' } }] |
Member
Author
There was a problem hiding this comment.
Unrelated change: I stumbled upon this aggregation which is never used. I could make a new PR but it felt small enough to go into this one.
sorenlouv
commented
Nov 27, 2018
| } should fail with a Boom error`, async () => { | ||
| await expect(route[0].handler(mockReq)).rejects.toMatchObject({ | ||
| test(`${route.method} ${route.path}"`, async () => { | ||
| await expect(route.handler(mockReq)).rejects.toMatchObject({ |
Member
Author
There was a problem hiding this comment.
Contributor
💚 Build Succeeded |
jasonrhodes
approved these changes
Nov 28, 2018
| } should fail with a Boom error`, async () => { | ||
| await expect(route[0].handler(mockReq)).rejects.toMatchObject({ | ||
| test(`${route.method} ${route.path}"`, async () => { | ||
| await expect(route.handler(mockReq)).rejects.toMatchObject({ |
sorenlouv
added a commit
that referenced
this pull request
Nov 28, 2018
…[APM] Get rid of `pre` middleware (#26256) (#26328) * [APM] Move chartsSelector transformation to backend (#26117) * [APM] Move ML anomaly transformation to backend Move apmTimeseries to backend Fix tests * Update default values * Fix bug * [APM] Get rid of `pre` middleware (#26256) Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query Fix tests Remove unused aggregation Revert "Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query" This reverts commit 5aa86744a0b360ceb75a59ebc8a0a084b24fbe50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using indirection to get
setupwe now simply call the method directly. Feels simpler and less code. And Typescript works out of the box :)