[kbn/i18n] remove npm-run-all#26297
Merged
spalger merged 7 commits intoelastic:masterfrom Nov 28, 2018
Merged
Conversation
Contributor
💚 Build Succeeded |
azasypkin
approved these changes
Nov 28, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nits.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 28, 2018
* [kbn/i18n] remove npm-run-all * remove unnecessary package * loop through babel sub tasks and use helper for task name padding * add --source-maps flag * update yarn.lock
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 28, 2018
* [kbn/i18n] remove npm-run-all * remove unnecessary package * loop through babel sub tasks and use helper for task name padding * add --source-maps flag * update yarn.lock
spalger
pushed a commit
that referenced
this pull request
Nov 29, 2018
spalger
pushed a commit
that referenced
this pull request
Nov 29, 2018
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen a number of failures on CI complaining that "run-p: command not found", and it looks like we've seen a similar failure about 7 times in the last couple days since it was merged, so I'm going to remove the
npm-run-allmodule that I added in #26097 in order to run the@kbn/i18nbuild tasks in quiet mode and in parallel. Instead I'm mimicking the build task I added to@kbn/interpreter.