[Canvas] Single POST when manipulating multiple elements#26119
Merged
[Canvas] Single POST when manipulating multiple elements#26119
Conversation
monfera
added
the
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
monfera
changed the title
Contributor
💚 Build Succeeded |
7 tasks
Contributor
Author
|
@rashidkpc @timroes should it be backported to 6.5 and 6.x? |
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Nov 28, 2018
* Feature: POST only once even when updating multiple Canvas elements * Chore: remove disused action
This was referenced Nov 28, 2018
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Nov 28, 2018
* Feature: POST only once even when updating multiple Canvas elements * Chore: remove disused action
monfera
added a commit
that referenced
this pull request
Nov 28, 2018
monfera
added a commit
that referenced
this pull request
Nov 28, 2018
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Nov 28, 2018
* Feature: POST only once even when updating multiple Canvas elements * Chore: remove disused action (cherry picked from commit f27a0d7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the introduction of selecting and manipulating multiple elements in Canvas (multiselect with
Shiftand clicks), a position change of the ad-hoc group resulted in multiple updates: one per element in the group. This contributes to slow performance of persisting changes. This PR batches the changes before a request is issued.Another PR with a related performance enhancement potential is #26092 - slow performance arises due to a combination of various causes.
Without this PR it looked like this:
Checklist
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately