Decoupling UI Settings from buildEsQuery #25994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Could you rebase on master, so this is easier to review? :) |
markov00
force-pushed
the
kql_decuple_config
branch
from
c8c0dfd to
55a5999
Compare
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lukasolson
approved these changes
Nov 27, 2018
Contributor
lukasolson
left a comment
lukasolson
left a comment
There was a problem hiding this comment.
LGTM! Code review & checked it out and tested manually and things seemed to be working properly.
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Feb 1, 2019
* Decuple the UI setting config from kbn-es-query package * Remove BuildESQueryProvider on ml utils
markov00
added a commit
that referenced
this pull request
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decoupling buildEsQuery from UI setting config object. We removed the uiSettings object in favour to a simple js object with the required params:
{ allowLeadingWildcards: boolean, queryStringOptions: any }In preparation for #17722
This PR is branched from #23345, so it's recommended to merge that PR before this one.
Note to reviewers:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately