Skip to content

Conversation

@w4tchdoge
Copy link
Contributor

@w4tchdoge w4tchdoge commented Oct 15, 2025

  • Change checkver to use JSONPath, and update the regex to account for the -x64 in the filename of the latest release.
  • Change autoupdate to use the new named captured variable in checkver.
  • Add architecture field to support 64-bit only. Move URL & hash under architecture.64bit.

Closes #16342

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated FontForge to the 20251009 release.
    • Switched to the Windows x64 installer and refreshed its checksum.
    • Reorganized release metadata to target 64-bit architecture.
    • Improved auto-update detection by switching to the GitHub releases API and using browser-download matching for more reliable updates.

- Change checkver to use jsonpath, and update the regex to account for
  the "x64" in the filename of the latest release
- Change autoupdate to use the new named captured variable
@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Walkthrough

Updated bucket/fontforge.json: bumped version to 20251009, moved Windows x64 download URL and SHA256 under an architecture.64bit block, replaced page-scraping checkver with GitHub Releases API + jsonpath/regex, and adjusted autoupdate to use $version and $matchFname.

Changes

Cohort / File(s) Change summary
FontForge manifest update
bucket/fontforge.json
Bumped version to 20251009; moved top-level url/hash into architecture.64bit with Windows x64 url and hash; replaced checkver to use https://api.github.com/repositories/5390156/releases/latest + jsonpath ($..browser_download_url) and a new regex; updated autoupdate to architecture.64bit.url template using $version and $matchFname.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User as Maintainer
  participant Scoop as checkver.ps1
  participant GH as GitHub API (releases/latest)
  participant Manifest as fontforge.json

  User->>Scoop: run checkver for fontforge
  Scoop->>GH: GET /repositories/5390156/releases/latest
  GH-->>Scoop: JSON (assets[].browser_download_url)
  Scoop->>Scoop: extract with jsonpath ($..browser_download_url)
  Scoop->>Scoop: apply regex -> capture version + filename
  Scoop-->>User: return version 20251009 and filename
  User->>Manifest: update version, architecture.64bit.url, architecture.64bit.hash, autoupdate template
  Note over Manifest,Scoop: future autoupdate uses $version and $matchFname
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • z-Fng

Poem

I hop through hashes, swift and keen,
New version carrots crisp and clean.
I sniff the API’s latest breeze,
Catch filenames rustling in the trees.
With regex whiskers, I align — Scoop scoops the goods, install’s fine. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues Check ✅ Passed All primary coding-related objectives from linked issue #16342 are met by the changes. The PR updates FontForge to version 20251009 as required, restructures checkver to use the GitHub API with JSONPath extraction of browser_download_url, updates the regex to account for the -x64 filename pattern, implements the architecture field for 64-bit support, and updates autoupdate to use the new named capture variable from checkver. The changes directly address the checkver failure and regex mismatch errors reported in the issue.
Out of Scope Changes Check ✅ Passed All changes in the pull request are directly in scope with the requirements from linked issue #16342. The modifications include version updates, checkver restructuring with JSONPath and regex fixes, autoupdate refactoring, architecture field addition, and corresponding hash and URL updates—all necessary to resolve the reported bug and meet the stated objectives. No unrelated changes or extraneous modifications are present in the changeset.
Description Check ✅ Passed The PR description follows the repository template structure and includes all required elements: a clear description of changes (explaining the checkver and autoupdate modifications), a proper issue reference ("Closes #16342"), and both checklist items marked as completed. The author has confirmed reading the Contributing Guide and used a conventional PR title as required. The description content is specific and relates directly to the code changes being made.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title "fontforge: Update to version 20251009, fix checkver & autoupdate, drop 32bit support" accurately reflects the main changes in the changeset. It specifically identifies the version update to 20251009, the fixes to the checkver and autoupdate mechanisms, and the architectural restructuring that drops 32-bit support. The title is concrete and specific, avoiding vague language, and clearly communicates the key changes in the pull request in a way that a team member scanning commit history would understand the nature of the work.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

fontforge

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng
Copy link
Member

z-Fng commented Oct 17, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

fontforge

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: fontforge not up-to-date, error when autoupdating

2 participants