-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fontforge: Update to version 20251009, fix checkver & autoupdate, drop 32bit support #16343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change checkver to use jsonpath, and update the regex to account for the "x64" in the filename of the latest release - Change autoupdate to use the new named captured variable
WalkthroughUpdated Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User as Maintainer
participant Scoop as checkver.ps1
participant GH as GitHub API (releases/latest)
participant Manifest as fontforge.json
User->>Scoop: run checkver for fontforge
Scoop->>GH: GET /repositories/5390156/releases/latest
GH-->>Scoop: JSON (assets[].browser_download_url)
Scoop->>Scoop: extract with jsonpath ($..browser_download_url)
Scoop->>Scoop: apply regex -> capture version + filename
Scoop-->>User: return version 20251009 and filename
User->>Manifest: update version, architecture.64bit.url, architecture.64bit.hash, autoupdate template
Note over Manifest,Scoop: future autoupdate uses $version and $matchFname
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. fontforge
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. fontforge
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
checkverto use JSONPath, and update the regex to account for the-x64in the filename of the latest release.autoupdateto use the new named captured variable incheckver.architecturefield to support 64-bit only. Move URL & hash under architecture.64bit.Closes #16342
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit