-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fvim: Update to version 0.3.549, fix checkver & autoupdate #16373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughVersion bumped to 0.3.549+ee4316c; release URLs and hashes for x64 and arm64 updated. checkver migrated from a GitHub+regex approach to a PowerShell script that queries the GitHub Releases API and emits a composite string including tag, version, and precomputed asset URLs; autoupdate now uses those captured URL fields. Changes
Sequence Diagram(s)sequenceDiagram
participant Manifest as Scoop manifest (`fvim.json`)
participant PS as checkver PowerShell script
participant GH as GitHub Releases API
participant Parser as Scoop checkver parser
participant Autoupdate as autoupdate fields
Manifest->>PS: invoke checkver script
PS->>GH: request releases for repo (query)
GH-->>PS: returns releases JSON (assets included)
PS-->>Parser: output composite string (tag | version | url_x64 | url_arm64)
Parser->>Autoupdate: populate capture groups (matchVersion, matchUrlx64, matchUrlarm64)
Autoupdate-->>Manifest: autoupdate uses \\$matchUrlx64 / \\$matchUrlarm64 for update URLs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. fvim
|
|
I believe we don't need to keep |
|
I removed |
|
/verify |
|
All changes look good. Wait for review from human collaborators. fvim
|
Changes:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit