Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 19, 2025

Changes:

  • Scripted custom checkver logic because author does a lot non-standard stuff with versioning, tag name of releases, and naming release artifacts.
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Release
    • Version bumped to 0.3.549+ee4316c with updated 64‑bit and arm64 assets and checksums.
  • Updates
    • Improved update detection and delivery to reliably fetch the latest release and provide the correct 64‑bit and arm64 downloads.

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

Version bumped to 0.3.549+ee4316c; release URLs and hashes for x64 and arm64 updated. checkver migrated from a GitHub+regex approach to a PowerShell script that queries the GitHub Releases API and emits a composite string including tag, version, and precomputed asset URLs; autoupdate now uses those captured URL fields.

Changes

Cohort / File(s) Summary
fvim manifest update
bucket/fvim.json
Version updated to 0.3.549+ee4316c; x64 and arm64 release URLs and hashes refreshed; checkver replaced from regex-based GitHub check to a PowerShell script that queries the GitHub API and outputs a composite match string; autoupdate changed to use precomputed named captures (\\$matchUrlx64, \\$matchUrlarm64) instead of constructing URLs from version/commit.

Sequence Diagram(s)

sequenceDiagram
    participant Manifest as Scoop manifest (`fvim.json`)
    participant PS as checkver PowerShell script
    participant GH as GitHub Releases API
    participant Parser as Scoop checkver parser
    participant Autoupdate as autoupdate fields

    Manifest->>PS: invoke checkver script
    PS->>GH: request releases for repo (query)
    GH-->>PS: returns releases JSON (assets included)
    PS-->>Parser: output composite string (tag | version | url_x64 | url_arm64)
    Parser->>Autoupdate: populate capture groups (matchVersion, matchUrlx64, matchUrlarm64)
    Autoupdate-->>Manifest: autoupdate uses \\$matchUrlx64 / \\$matchUrlarm64 for update URLs
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • z-Fng

Poem

🐰 I hopped through tags and API light,
Fetched the assets, both left and right.
A composite string, tidy and new,
URLs ready — updates hop through! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The PR description includes the key required elements from the template: a clear summary explaining that custom checkver logic was scripted to handle the author's non-standard versioning approach, and both required checkboxes are marked as complete. The PR title "[email protected]+ee4316c: Fix checkver and autoupdate" follows the conventional format specified in the template (<manifest-name[@version]>: <general summary>), and the author confirms reading the Contributing Guide. While the description is concise and lacks an explicit issue reference (Closes/Relates to), these are non-critical sections, and the provided information clearly communicates the purpose and scope of the changes.
Title Check ✅ Passed The PR title "fvim: Update to version 0.3.549, fix checkver & autoupdate" directly addresses the main changes in the changeset. It clearly identifies the package (fvim), specifies the version update (0.3.549), and explicitly mentions the two primary fixes implemented (checkver and autoupdate). The title is concise, specific, and follows the repository's conventional format <manifest-name[@version]>: <general summary>, making it easy for teammates to understand the primary objectives when scanning history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

fvim

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@SorYoshino
Copy link
Contributor

I believe we don't need to keep +ee4316c in the version field. Using just 0.3.549 is sufficient, as previous releases show that the [\d.]+ part has never been duplicated, so no additional information is needed to distinguish versions.

@o-l-a-v o-l-a-v changed the title [email protected]+ee4316c: Fix checkver and autoupdate [email protected]: Fix checkver and autoupdate Oct 21, 2025
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 21, 2025

I removed +ee4316c as suggested by @SorYoshino. I kept the old version format in the checkver logic as $matchTagname, in case it's needed in the future.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 21, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

fvim

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title [email protected]: Fix checkver and autoupdate fvim: Update to version 0.3.549, fix checkver & autoupdate Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants